rastertoescpx: validate PPD row geometry before sizing - #720
Open
carrerasdarren-cell wants to merge 1 commit into
Open
rastertoescpx: validate PPD row geometry before sizing#720carrerasdarren-cell wants to merge 1 commit into
carrerasdarren-cell wants to merge 1 commit into
Conversation
Apply cupsESCPBlack overrides before calculating softweave schedules and buffer capacities. Reject invalid or overflowing row geometry, use checked size_t arithmetic for the compression allocation, and handle the affected allocation failures. This prevents the undersized compression buffer reported in issue OpenPrinting#715.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cupsESCPBlackrow overrides before deriving softweave schedules and buffer sizessize_tarithmetic and verify the affected allocationsProblem
StartPage()calculatedDotRowMaxand the compression-buffer capacity from the raster header, then allowedcupsESCPBlackto replaceDotRowCountandDotRowStep. The PPD from #715 changes the row count from 2 to 30, so a 29-row band reachesCompressData()whileCompBufferstill has capacity for only two rows.The override is now parsed and validated before any dependent state is calculated. The validation also bounds the fixed 128-entry weave schedule and prevents integer overflow in the compression allocation.
Fixes #715.
Testing
DotRowMax = 302 1control: byte-identical output before and after the patch0 1,30 0,2147483647 2,30 129, and malformed controls: rejected cleanlymake -j2 check