Conversation
- Integrated APScheduler to manage daily cleanup of expired verses of the day. - Added configuration for verse retention period in `config.py`. - Implemented `cleanup_expired_verses_of_day` function to delete verses older than the specified expiry days. - Updated database interaction to support deletion of expired verses. - Created tests to validate the cleanup functionality and ensure correct behavior.
Confidence Score: 5/5This looks safe to merge.
Reviews (2): Last reviewed commit: "Enhance error handling for scheduler and..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
|
it looks like sonarqube server is down for some reason. lets check later on |
Tech-lo
approved these changes
Jul 17, 2026
- Added validation to ensure `VERSE_OF_DAY_EXPIRY_DAYS` and `expiry_days` are positive integers, raising `ValueError` for invalid inputs. - Updated the `lifespan` function to ensure proper cleanup of resources during initialization failures. - Added tests to verify the new validation logic for both the scheduler setup and the cleanup function.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.py.cleanup_expired_verses_of_dayfunction to delete verses older than the specified expiry days.