Sorting verse#856
Conversation
Confidence Score: 5/5The changed flow looks mergeable after a small cleanup to search matching.
pecha_api/verse_of_day/verse_of_day_repository.py Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/dev..." | Re-trigger Greptile |
|
|
||
| if search: | ||
| query = query.filter( | ||
| VerseOfDay.verse_metadata.any(VerseMetadata.verse.ilike(f"%{search}%")) |
There was a problem hiding this comment.
Wildcard Search Matches Everything
When search contains SQL LIKE metacharacters such as % or _, the new ilike pattern treats them as wildcards instead of literal text. A CMS request like search=% or search=_ can therefore return nearly every verse rather than verses containing those characters, so users get broad false-positive results from the list endpoint.
|



added sort_order + search to the verse-of-day list endpoint