Skip to content

Sorting verse#856

Merged
Tech-lo merged 3 commits into
developfrom
sorting-verse
Jul 13, 2026
Merged

Sorting verse#856
Tech-lo merged 3 commits into
developfrom
sorting-verse

Conversation

@Tech-lo

@Tech-lo Tech-lo commented Jul 13, 2026

Copy link
Copy Markdown
Member

added sort_order + search to the verse-of-day list endpoint

@Tech-lo
Tech-lo requested a review from tenkus47 July 13, 2026 10:30
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The changed flow looks mergeable after a small cleanup to search matching.

  • The default date order still matches the old descending behavior.
  • Date ordering is stable because verse dates are unique.
  • Search works through the expected relationship, but wildcard characters can broaden matches unexpectedly.

pecha_api/verse_of_day/verse_of_day_repository.py

Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/dev..." | Re-trigger Greptile


if search:
query = query.filter(
VerseOfDay.verse_metadata.any(VerseMetadata.verse.ilike(f"%{search}%"))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Wildcard Search Matches Everything

When search contains SQL LIKE metacharacters such as % or _, the new ilike pattern treats them as wildcards instead of literal text. A CMS request like search=% or search=_ can therefore return nearly every verse rather than verses containing those characters, so users get broad false-positive results from the list endpoint.

@sonarqubecloud

Copy link
Copy Markdown

@Tech-lo
Tech-lo merged commit 1428baf into develop Jul 13, 2026
11 checks passed
@Tech-lo
Tech-lo deleted the sorting-verse branch July 13, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants