NMS-19557: Ensure Snmp config management works with IPv4 and IPv6#8420
Merged
NMS-19557: Ensure Snmp config management works with IPv4 and IPv6#8420
Conversation
synqotik
force-pushed
the
jira/NMS-19557-snmp-config-ipv6-updates
branch
2 times, most recently
from
b8ec568 to
1acc778
Compare
synqotik
force-pushed
the
jira/NMS-19557-snmp-config-ipv6-updates
branch
from
1acc778 to
d2665bd
Compare
cgorantla
reviewed
Apr 8, 2026
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Looks good. One minor comment
opennms-config/src/main/java/org/opennms/netmgt/config/SnmpConfigUtils.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that
SnmpConfigManager,SnmpPeerFactoryandSnmpConfigRestServicework with IPv6, with all the recent SNMP Config updates.Ensure that adding/merging and deleting definitions with IPv4 and/or IPv6 ranges, specific IPs and ipMatch IPLIKE expressions all work correctly.
Refactored some of the validation code that was in
SnmpConfigRestServiceintoopennms-configSnmpConfigUtilsas it was cluttering up the Rest service and now can be tested independently.Added a bunch of tests for everything.
External References