Skip to content

NMS-19642: add API token authentication for REST API access#8418

Open
cnewkirk wants to merge 1 commit intoOpenNMS:developfrom
cnewkirk:feat/NMS-19642/api-token-support
Open

NMS-19642: add API token authentication for REST API access#8418
cnewkirk wants to merge 1 commit intoOpenNMS:developfrom
cnewkirk:feat/NMS-19642/api-token-support

Conversation

@cnewkirk
Copy link
Copy Markdown
Contributor

@cnewkirk cnewkirk commented Apr 5, 2026

All Contributors

Contribution Checklist

  • Please make an issue in the OpenNMS issue tracker if there isn't one already.
    Once there is an issue, please:
    1. update the title of this PR to be in the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the Jira link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
    4. once you've created this PR, please link to it in a comment in the Jira issue
      Don't worry if this sounds like a lot, we can help you get things set up properly.
  • If this code is likely to affect the UI, did you name your branch with -smoke in it to trigger smoke tests?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it try to avoid changing files in $OPENNMS_HOME/etc/?

What's Next?

A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.

If you need help making additions or changes to the documentation related to your changes, please let us know.

In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.

Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

@github-actions github-actions bot requested a review from indigo423 April 5, 2026 00:16
@github-actions github-actions bot added the docs label Apr 5, 2026
Copy link
Copy Markdown
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cnewkirk for your contribution.

This is definitely a valuable feature.

We are targeting some Spring/Hibernate updates in the next few Horizon versions. It will be easier to tackle this feature after those updates to avoid conflicts.

As for the code, ideally this should be completely Spring bean based feature as it needs to work with Spring security and this shouldn't expose an OSGi feature.

Once we get the Spring/Hibernate updates in and this is refactored, we also need to make sure this gets thoroughly tested and reviewed. We'll need some help from the community to make sure that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants