NMS-19642: add API token authentication for REST API access#8418
Open
cnewkirk wants to merge 1 commit intoOpenNMS:developfrom
Open
NMS-19642: add API token authentication for REST API access#8418cnewkirk wants to merge 1 commit intoOpenNMS:developfrom
cnewkirk wants to merge 1 commit intoOpenNMS:developfrom
Conversation
cgorantla
reviewed
Apr 8, 2026
Contributor
cgorantla
left a comment
There was a problem hiding this comment.
Thanks @cnewkirk for your contribution.
This is definitely a valuable feature.
We are targeting some Spring/Hibernate updates in the next few Horizon versions. It will be easier to tackle this feature after those updates to avoid conflicts.
As for the code, ideally this should be completely Spring bean based feature as it needs to work with Spring security and this shouldn't expose an OSGi feature.
Once we get the Spring/Hibernate updates in and this is refactored, we also need to make sure this gets thoroughly tested and reviewed. We'll need some help from the community to make sure that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Contributors
Contribution Checklist
Once there is an issue, please:
${JIRA-ISSUE-NUMBER}: subject of pull requestDon't worry if this sounds like a lot, we can help you get things set up properly.
-smokein it to trigger smoke tests?foundation-*branch, does it try to avoid changing files in$OPENNMS_HOME/etc/?What's Next?
A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.
If you need help making additions or changes to the documentation related to your changes, please let us know.
In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.
Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.
At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.
Thanks for taking time to contribute!
External References