Skip to content

NMS-19652: Update documentation for trapd config#8411

Merged
Shahbaz-dataq merged 56 commits intofeatures/trapd-config-db-migrationfrom
jira/NMS-19652-trapd-documentation
Apr 7, 2026
Merged

NMS-19652: Update documentation for trapd config#8411
Shahbaz-dataq merged 56 commits intofeatures/trapd-config-db-migrationfrom
jira/NMS-19652-trapd-documentation

Conversation

@Shahbaz-dataq
Copy link
Copy Markdown
Contributor

External References

@github-actions github-actions bot added the docs label Apr 1, 2026
Base automatically changed from jira/NMS-19621-integrate-trapd-UI-endpoints to features/trapd-config-db-migration April 6, 2026 16:13
@Shahbaz-dataq Shahbaz-dataq marked this pull request as ready for review April 6, 2026 17:44
Copy link
Copy Markdown
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small fix.

= Trapd REST API (v2)
:description: Manage trapd configuration through the OpenNMS REST v2 API.

You can read and update trapd configuration over REST without editing `trapd-configuration.xml` manually.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change line 5 to just:

You can view and update trapd configuration over REST.

I think we want to downplay that there's even an XML file at all.

Copy link
Copy Markdown
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shahbaz-dataq Shahbaz-dataq requested a review from synqotik April 7, 2026 05:17
@Shahbaz-dataq Shahbaz-dataq merged commit af749fc into features/trapd-config-db-migration Apr 7, 2026
5 checks passed
@Shahbaz-dataq Shahbaz-dataq deleted the jira/NMS-19652-trapd-documentation branch April 7, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants