Skip to content

NMS-19176: Upload,Compile,Delete and get and set text of mib files#8388

Open
aurang-zeb313 wants to merge 6 commits intofeatures/mib-compilerfrom
akhan/jira/NMS-19176
Open

NMS-19176: Upload,Compile,Delete and get and set text of mib files#8388
aurang-zeb313 wants to merge 6 commits intofeatures/mib-compilerfrom
akhan/jira/NMS-19176

Conversation

@aurang-zeb313
Copy link
Copy Markdown
Member

External References

…ending and compiled mib files text and set text of mib files
…ending and compiled mib files text and set text of mib files
@aurang-zeb313 aurang-zeb313 changed the base branch from develop to features/mib-compiler March 25, 2026 18:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the REST-side functionality needed for managing MIB files (upload, compile, list, delete, and read/write contents) in the features/mib-compiler/rest module, wiring in a new file service and adding DTOs and tests.

Changes:

  • Implemented MibCompilerRestServiceImpl endpoints for upload/compile/list/delete/get/set text backed by a new MibCompilerFileService.
  • Added REST model DTOs (CompileMibResult, MibCompilerFileInfo, MibCompilerFileText) and updated OSGi blueprint wiring.
  • Added an integration-style test class and updated module dependencies.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java Implements REST operations and response mapping for MIB file management.
features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerFileService.java Adds filesystem operations for pending/compiled directories and compilation flow.
features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/MibCompilerRestService.java Extends REST API surface with file-management endpoints and compile changes.
features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/model/MibCompilerFileInfo.java DTO for listing files and their location.
features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/model/MibCompilerFileText.java DTO for returning file text contents.
features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/model/CompileMibResult.java Internal result type for compile outcomes and error reporting.
features/mib-compiler/rest/src/main/resources/OSGI-INF/blueprint/blueprint.xml Wires new MibCompilerFileService bean and injects it into the REST service.
features/mib-compiler/rest/src/test/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImplIT.java Adds tests for list/delete/get/set/upload behaviors.
features/mib-compiler/rest/pom.xml Adds provided/test dependencies for the new implementation and tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants