NMS-19176: Upload,Compile,Delete and get and set text of mib files#8388
Open
aurang-zeb313 wants to merge 6 commits intofeatures/mib-compilerfrom
Open
NMS-19176: Upload,Compile,Delete and get and set text of mib files#8388aurang-zeb313 wants to merge 6 commits intofeatures/mib-compilerfrom
aurang-zeb313 wants to merge 6 commits intofeatures/mib-compilerfrom
Conversation
…ending and compiled mib files text and set text of mib files
…ending and compiled mib files text and set text of mib files
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the REST-side functionality needed for managing MIB files (upload, compile, list, delete, and read/write contents) in the features/mib-compiler/rest module, wiring in a new file service and adding DTOs and tests.
Changes:
- Implemented
MibCompilerRestServiceImplendpoints for upload/compile/list/delete/get/set text backed by a newMibCompilerFileService. - Added REST model DTOs (
CompileMibResult,MibCompilerFileInfo,MibCompilerFileText) and updated OSGi blueprint wiring. - Added an integration-style test class and updated module dependencies.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java | Implements REST operations and response mapping for MIB file management. |
| features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerFileService.java | Adds filesystem operations for pending/compiled directories and compilation flow. |
| features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/MibCompilerRestService.java | Extends REST API surface with file-management endpoints and compile changes. |
| features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/model/MibCompilerFileInfo.java | DTO for listing files and their location. |
| features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/model/MibCompilerFileText.java | DTO for returning file text contents. |
| features/mib-compiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/model/CompileMibResult.java | Internal result type for compile outcomes and error reporting. |
| features/mib-compiler/rest/src/main/resources/OSGI-INF/blueprint/blueprint.xml | Wires new MibCompilerFileService bean and injects it into the REST service. |
| features/mib-compiler/rest/src/test/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImplIT.java | Adds tests for list/delete/get/set/upload behaviors. |
| features/mib-compiler/rest/pom.xml | Adds provided/test dependencies for the new implementation and tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c/test/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImplIT.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImplIT.java
Outdated
Show resolved
Hide resolved
...ompiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/MibCompilerRestService.java
Outdated
Show resolved
Hide resolved
...ompiler/rest/src/main/java/org/opennms/features/mibcompiler/rest/MibCompilerRestService.java
Outdated
Show resolved
Hide resolved
...est/src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerFileService.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImplIT.java
Show resolved
Hide resolved
cgorantla
reviewed
Apr 6, 2026
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/features/mibcompiler/rest/internal/MibCompilerRestServiceImpl.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External References