NMS-19575: Moving eventconf.xml to DB#8384
Open
christianpape wants to merge 3 commits intodevelopfrom
Open
Conversation
cgorantla
reviewed
Mar 26, 2026
Contributor
cgorantla
left a comment
There was a problem hiding this comment.
Need to update docs about this and also update breaking changes.
...rc/main/java/org/opennms/upgrade/implementations/EventConfGlobalSecurityMigratorOffline.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/opennms/upgrade/implementations/EventConfGlobalSecurityMigratorOffline.java
Outdated
Show resolved
Hide resolved
opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/EventConfGlobalSecurityDao.java
Outdated
Show resolved
Hide resolved
opennms-config/src/main/java/org/opennms/netmgt/config/DefaultEventConfDao.java
Outdated
Show resolved
Hide resolved
opennms-model/src/main/java/org/opennms/netmgt/model/EventConfGlobalSecurityDto.java
Outdated
Show resolved
Hide resolved
336a340 to
f6c8435
Compare
f6c8435 to
bc6501d
Compare
cgorantla
reviewed
Apr 7, 2026
opennms-config/src/main/java/org/opennms/netmgt/config/DefaultEventConfDao.java
Outdated
Show resolved
Hide resolved
cgorantla
reviewed
Apr 9, 2026
Contributor
cgorantla
left a comment
There was a problem hiding this comment.
I think we need additional code to update default doNotOverride fields either through liquibase change or through code for fresh installations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.