Use label values API for efficient wildcard resource discovery#110
Open
cnewkirk wants to merge 4 commits intoOpenNMS:masterfrom
Open
Use label values API for efficient wildcard resource discovery#110cnewkirk wants to merge 4 commits intoOpenNMS:masterfrom
cnewkirk wants to merge 4 commits intoOpenNMS:masterfrom
Conversation
added 4 commits
March 15, 2026 18:03
Two-phase discovery: /api/v1/label/resourceId/values for resourceId enumeration, then batched /series queries with exact-match alternation for metric retrieval. Configurable via useLabelValuesForDiscovery (default false) and discoveryBatchSize (default 50). Includes E2E test harness (45 tests, Prometheus + Thanos profiles), architecture docs, and AGPL license headers on new files.
Codifies guardrails against recurring regressions: pinned image versions, no SNAPSHOT testing, observable-behavior assertions, 30s collection intervals, and scope discipline.
- run-e2e.sh: single command for build, deploy, start, test, teardown - e2e.yml: runs 45 smoke tests on PR against both Prometheus and Thanos - CLAUDE.md updated with automation docs
- Correct writeTimeoutInMs/readTimeoutInMs examples: 1000 -> 5000 (actual defaults) - Rename bulkheadMaxWaitDurationInMs -> bulkheadMaxWaitDuration to match OSGi property name in blueprint.xml - Remove stale integration test count (~15 -> varies)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1/label/resourceId/valuesfor resourceId enumeration, then batched/seriesqueries with exact-match alternation. Configurable viauseLabelValuesForDiscovery(default false) anddiscoveryBatchSize(default 50).e2e/): 45 smoke tests across 12 sections, supporting both Prometheus and Thanos backends via docker-compose profiles. Single-command orchestration viarun-e2e.sh.Test plan
mvn test./e2e/run-e2e.sh --backend thanos./e2e/run-e2e.sh --backend prometheus