Conversation
Contributor
|
I don't really understand why we are usingMakefiles when similar actions was done by CircleCI; |
Member
Author
because you can run everything locally and you don't depend on the underlying CI/CD. |
Add Makefile so everyone can build and make releases easily. Added a CI/CD pipeline job to release to GitHub. Signed-off-by: Ronny Trommer <ronny@no42.org>
Describe the procedure how to create release. Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Member
Author
... anything else? |
Contributor
|
The plugin uses java 11, why do we want the CICD to use java 17? |
Signed-off-by: Ronny Trommer <ronny@no42.org>
Member
Author
See source/target. Nevertheless, this is outdated and can be replaced with release. See https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html |
Signed-off-by: Ronny Trommer <ronny@no42.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to build from source with a release workflow. Added a GitHub release job in CI/CD. I have also replaced the legacy container images for OpenJDK 11 and build with the latest Ubuntu 24 LTS. The OpenJDK build environment is upgraded from 11 to 17 because it isn't available in the Ubuntu machine images.
Resolve: #102