add speak detection in om1 - #2676
Open
WenjinFu wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
openminddev
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. OM1 —
add-speak-detectionSpeaker attribution: OM1 knows who is talking
Every turn, OM1 now tells the model which person in view actually spoke —
and when someone says "my name is Sean", the name is saved against that
person, not whoever happens to be most prominent in frame.
How it works
Changes
internal/providers/speaker.goplugins/inputs/asr/asr_stream.gointernal/providers/face_presence.goplugins/actions/face_memory/face_memory.goset_nametargets the measured speaker (uuid, track_id fallback)internal/actions/schema.goBuildSchemahonoursjson:",omitempty"internal/runtime/runtime.goconfig/*.json5Testing
go build ./...andgo test ./...pass — 3 new test files, ~950 lines.(The 3 pre-existing
TestConfigFilesMatchSchemafailures are unrelated tothis branch.) Verified end-to-end on a G1: person introduces themselves,
gallery and visualization update to their name, including for someone standing
beside the tracked person.
Depends on
OM1-video-processor:
/speakingendpoint + profile-face support in LR-ASD.