fix(holocron): citation rendering and GitHub permalink source labels#98
Open
th3w1zard1 wants to merge 16 commits into
Open
fix(holocron): citation rendering and GitHub permalink source labels#98th3w1zard1 wants to merge 16 commits into
th3w1zard1 wants to merge 16 commits into
Conversation
Harden ci_warm_trask_embed cache probe and attempts validation; grant build-and-test actions: write so Actions cache can save FastEmbed/Chroma.
Use /projects, /faq, and /formats instead of hash anchors to match openkotor/site routing.
Holocron browser MCP 5/5 on :4010 with fresh threads; refresh evidence and mark pass-5 plan completed after PR #96 merge.
…ealth The qa-webui was stuck on Dispatching because trask-worker proxied to an HF Space in ERROR (503) with no UI feedback. Add upstream health probing on the worker, structured API errors, a Holocron backend status banner, bounded retry failure messages, BASE_URL-safe assets, Spark stub for Pages builds, and CI scripts that block deploy when /healthz or /api/trask/ask are unhealthy.
Strip spaced markdown links and images from visible answer text while preserving [n] markers, move trailing numbered bibliography into the Sources panel when the model omits a heading, and tighten compose-side markdown cleanup in grounded-evidence.
Strip http URLs before inferring repo file paths, sanitize malformed blob segments to README.md, and share webCitationDisplayLabel with Holocron via @openkotor/trask/github-citation-url. Refresh docs/solutions for e2e paths, gate floor 165, and Holocron source-card contract.
Apply code-review autofix: numbered instructional steps without links stay in the answer body. Add regression test and LFG closeout plan 008.
When API sources merge with parsed bibliography lines, prefer the explicit citation URL and webCitationDisplayLabel so KotOR.js cards show README.md#Ln instead of raw.githubusercontent path noise.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Offline Playwright gate for five Discord /ask import-smoke embeds via a static harness; share display audit with verify_trask_discord_live. Holocron Playwright now rejects githubusercontent source labels and spaced markdown links.
Add plan 010 closeout for Discord harness + Holocron Playwright ladder.
All Playwright gates and agent-browser smoke verified on PR #98 branch.
Prior pushes after 6a54267 only ran CodeQL; empty commit to queue full CI.
Keep webCitationDisplayLabel integration, URL-required bibliography peel, and permalink merge labels from the citation e2e branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Holocron grounded answers no longer leak raw markdown links or duplicate numbered bibliographies in the visible answer body. Sources cards use GitHub permalink labels (
README.md#Ln) instead of mistakengithubusercontent.com/owner/repopaths when passages embed raw CDN URLs.Follows merged PR #97 (public API status); this PR ships citation presentation and permalink labeling commits that remained on the feature branch.
Changes
[label] (https://…)markdown, preserve[n]citation badges, peel trailing numbered bibliographies only when lines contain URLs.inferGitHubFilePathignores URL segments;webCitationDisplayLabelsanitizes malformed blob paths.answer-presentationhelpers; merge API sources with parsed lines using permalink URLs for display names.scripts/answer_presentation.test.mjs,packages/trask/src/github-citation-url.test.ts.Test plan
node --import tsx/esm --test scripts/answer_presentation.test.mjsnode --test packages/trask/dist/github-citation-url.test.js:4010reone query — grounded answer, citations[1]–[5], KotOR.js permalink…/README.md#L1in provenancepnpm trask:gate:ci, holocron workflows)Residual review findings
peelEmbeddedNumberedSourcesmay still attach prose after a two-line numbered block tosourceText(CORR-002); single trailing numbered source line is not peeled (CORR-003). Tracked for a follow-up if user reports.Plan
docs/plans/2026-06-04-008-feat-holocron-citation-permalink-lfg-closeout-plan.md