Rewrote base level self condition check

[hexhexD]

I will update wiki once this is merged.

[ya4ept]

On one hand i don't like this change because we break backward compatibility.
On the other hand, the syntax will be simplified a bit.
Please see autoConfChange
we use "lvl "instead of "baseLvl"

EventMacro:

$.lvl    Current base level
$.joblvl    Current job level

we need to decide what name to use next

new point

[ya4ept]

we also use "maxBase" here

Why do we use "maxBase" and "minBase" in the "processAutoBuy" function? This function uses the "checkSelfCondition" check, which is included by "maxBase" and "minBase". Need to re-review #2719

[ya4ept]

Renamed "joblvl" to "jobLvl" for the autoConfChange block
Renamed "lvl" to "baseLvl" for the autoConfChange block

We need:

• fix maxBase here (Need to re-review fix min/maxBase in buyAuto and accept nameID #2719)
• fix EventMacro (rename $.lvl to $.baselvl)
• fix macro (rename $.lvl to $.baselvl)
• do the final test
• update wiki (EventMacro)
• update wiki (macro_plugin)
• update wiki (autoConfChange)
• update wiki (Category:Self_Condition) (add baseLvl)

[ya4ept]

Renamed "$.lvl" to "$.baselvl" in eventMacro plugin
Renamed "$.lvl" to "$.baselvl" in macro plugun

[ya4ept]

We are not ready for the merger yet. What are we going to do about this?

• fix maxBase here (Need to re-review fix min/maxBase in buyAuto and accept nameID #2719)

[Henrybk]

Why not leave them both in Misc.pm and only change config.txt? That way backwards compatibility isn't broken and new code can be written with the new sintax

[ya4ept]

I think we haven't used backward compatibility for a long time now to make the code cleaner

[dcyxxt]

actually the wx inteface display the wrong exp block after Lv 230~,or maybe lv 240..

[ya4ept]

screenshot please

[Henrybk]

I mean the latest packets are using a int64 exp that we are not currently supporting so that could be possible

[dcyxxt]

screenshot please

[dcyxxt]

i mean base LV,not job

[dcyxxt]

screenshot please

Actually, this problem has been going on for a long time. I shouldn’t leave a comment under this post.

[ya4ept]

This issue does not apply to pull requests.

[yesits-me]

Suggested change

	baseLvl
	baseLvl