Skip to content

Alternate fix for conversations that stop responding due to stale execution status #2470

Open
DoubleDensity wants to merge 4 commits intoOpenHands:mainfrom
DoubleDensity:stuck_conversation_fix_alternate
Open

Alternate fix for conversations that stop responding due to stale execution status #2470
DoubleDensity wants to merge 4 commits intoOpenHands:mainfrom
DoubleDensity:stuck_conversation_fix_alternate

Conversation

@DoubleDensity
Copy link

… RUNNING reset already happens outside the loop at lines 586-592, so we shouldn't check for STUCK again inside the loop and break.

Summary

[fill in a summary of this PR]

Checklist

  • If the PR is changing/adding functionality, are there tests to reflect this?
  • If there is an example, have you run the example to make sure that it works?
  • If there are instructions on how to run the code, have you followed the instructions and made sure that it works?
  • If the feature is significant enough to require documentation, is there a PR open on the OpenHands/docs repository with the same branch name?
  • Is the github CI passing?

… RUNNING reset already happens outside the loop at lines 586-592, so we shouldn't check for STUCK again inside the loop and break.
@DoubleDensity
Copy link
Author

also did not fix the issue after further testing -- please do not merge yet

@DoubleDensity
Copy link
Author

this one looks promising, was able to resume a previously hung base_state.json at least. will continue testing to see if any stuck sessions occur again

@DoubleDensity
Copy link
Author

@OpenHands /codereview-roasted

@openhands-ai
Copy link

openhands-ai bot commented Mar 17, 2026

I'm on it! DoubleDensity can track my progress at all-hands.dev

@openhands-ai
Copy link

openhands-ai bot commented Mar 17, 2026

Summary

I analyzed PR #2470 "Alternate fix for conversations that stop responding due to stale execution status" and provided a code review using the /codereview-roasted persona.

What I did:

  1. Retrieved PR details and diff using GitHub CLI
  2. Analyzed the code changes in local_conversation.py
  3. Provided a code review with:
    • Verdict: ✅ Worth merging - the core fix (changing continue to break when stuck is detected) correctly addresses the infinite loop bug
    • Key finding: The original bug was that when stuck was detected, the code set status to STUCK and used continue, which would loop back. With STUCK removed from the break condition, it would keep looping infinitely. The fix correctly breaks out of the loop.
    • Minor improvement suggestions around documentation clarity and potential extraction of stuck detection logic into a helper method

I did not modify any code - the task was to provide a code review comment as requested by the /codereview-roasted command on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant