Alternate fix for conversations that stop responding due to stale execution status #2470
Open
DoubleDensity wants to merge 4 commits intoOpenHands:mainfrom
Open
Alternate fix for conversations that stop responding due to stale execution status #2470DoubleDensity wants to merge 4 commits intoOpenHands:mainfrom
DoubleDensity wants to merge 4 commits intoOpenHands:mainfrom
Conversation
… RUNNING reset already happens outside the loop at lines 586-592, so we shouldn't check for STUCK again inside the loop and break.
Author
|
also did not fix the issue after further testing -- please do not merge yet |
… loop, another check immediately broke if status was STUCK, preventing recovery
Author
|
this one looks promising, was able to resume a previously hung |
Author
|
@OpenHands /codereview-roasted |
|
I'm on it! DoubleDensity can track my progress at all-hands.dev |
SummaryI analyzed PR #2470 "Alternate fix for conversations that stop responding due to stale execution status" and provided a code review using the What I did:
I did not modify any code - the task was to provide a code review comment as requested by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… RUNNING reset already happens outside the loop at lines 586-592, so we shouldn't check for STUCK again inside the loop and break.
Summary
[fill in a summary of this PR]
Checklist