chore(agent-server): bump version for REST API breakage checks#2456
chore(agent-server): bump version for REST API breakage checks#2456
Conversation
Bump openhands-agent-server from 1.14.0 to 1.15.0 so the REST API breakage workflow reflects the current breaking API surface already present on main. This is intentionally separate from PR #2455, whose failing REST API check is unrelated to the browser timeout fix. Co-authored-by: openhands <openhands@all-hands.dev>
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
all-hands-bot
left a comment
There was a problem hiding this comment.
🔴 Needs improvement - This is treating a symptom (CI failure) instead of addressing the root cause.
VERDICT: ❌ Needs rework - Version bumps should happen in release PRs or alongside the changes that necessitate them, not as a workaround for CI checks.
KEY INSIGHT: The REST API breakage check is failing because changes merged to main after v1.14.0 introduced breaking changes without a version bump. Instead of bumping the version to make CI green, we need to understand what actually changed and handle it properly.
| [project] | ||
| name = "openhands-agent-server" | ||
| version = "1.14.0" | ||
| version = "1.15.0" |
There was a problem hiding this comment.
🔴 Critical - Policy Violation: Version bumps in non-release PRs are explicitly blocked by repository guidelines.
Per the custom code review guidelines:
Package version bumps in non-release PRs: If any
pyproject.tomlfile has changes to theversionfield, and the PR is NOT explicitly a release PR (title/description doesn't indicate it's a release), DO NOT APPROVE.
This PR is titled "chore(agent-server): bump version for REST API breakage checks" - it's using a version bump as a workaround to make CI pass, not as part of a proper release.
The real issue: The REST API breakage check compares the current workspace against the v1.14.0 git tag and found breaking changes. This means something merged to main after v1.14.0 was tagged introduced breaking changes without bumping the version.
Proper fixes:
-
Option A (Proper release): Make this a real release PR
- Change title to "release: v1.15.0" or similar
- Update description to document what's being released
- Add changelog/release notes
- Follow the project's release process
-
Option B (Fix the root cause): Identify which PR introduced the breaking change
- Review commits between v1.14.0 tag and main (e.g., Enforce REST deprecation deadlines #2435, Enable ACPAgent on RemoteRuntime API #2190, Export TokenUsage, page_iterator, and AsyncRemoteWorkspace as public SDK APIs #2445)
- Either revert the breaking change or properly document it
- Bump the version in the same PR that introduces breaking changes (not after the fact)
-
Option C (Fix false positive): If the "breaking change" is actually acceptable
- Investigate what oasdiff is flagging
- Update the check if it's a false positive
- Document why the change is not actually breaking
Using a version bump to bypass CI without understanding what changed is exactly the kind of hack that leads to versioning chaos and broken user expectations.
There was a problem hiding this comment.
Smart agent! 😅
I admit I'm a bit curious what LLM were you using in implementation @neubig , why didn't it see this
Edited to add: specially if it's GPT-5.4, I'm also curious if the prompt was generic or told it what to do
| [[package]] | ||
| name = "openhands-agent-server" | ||
| version = "1.14.0" | ||
| version = "1.15.0" |
There was a problem hiding this comment.
🟡 Suggestion: This is just a consequence of the pyproject.toml change. The real issue is above.
|
@OpenHands Look at this PR, it upgrades version. I thought we had a CI check for PRs to fail when PRs upgrade versions without them being a release PR. Find the check, and make sure it applies to agent-server too. |
|
I'm on it! enyst can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
|
I found that we didn't have an explicit PR guard for package version bumps here, so I added one and made it cover
I also updated the PR title/body to match the new scope. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This reverts commit 2368c7f.
|
Hi, I'm OpenHands-GPT-5.4. I moved the version-bump guard change out of this PR so the original scope stays intact. The isolated follow-up is here: #2457 I also reverted my previous commit from this branch and restored the original PR title/description. |
|
Closing this for now. It's pretty annoying to have the CI fail on every PR though because it confuses agents, we should try to fix this soon. |
Summary
openhands-agent-serverfrom1.14.0to1.15.0Checklist
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:eebb36d-pythonRun
All tags pushed for this build
About Multi-Architecture Support
eebb36d-python) is a multi-arch manifest supporting both amd64 and arm64eebb36d-python-amd64) are also available if needed