feat: add cache-mode input to image build workflows#536
Closed
simonrosenberg wants to merge 2 commits intomainfrom
Closed
feat: add cache-mode input to image build workflows#536simonrosenberg wants to merge 2 commits intomainfrom
simonrosenberg wants to merge 2 commits intomainfrom
Conversation
Wire up OPENHANDS_BUILDKIT_CACHE_MODE env var (from SDK PR #2479) as a workflow_dispatch input so callers can control BuildKit cache export behavior (max/min/off) when triggering image builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean, mechanical change that solves a real problem without over-engineering. The passthrough design preserves backward compatibility and adds exactly the control needed for batch builds. One minor process note about testing evidence below.
| @@ -266,6 +271,7 @@ jobs: | |||
| DOCKER_BUILDKIT: 1 | |||
Collaborator
There was a problem hiding this comment.
🟢 Acceptable: Correctly includes the cache-mode in both build steps (runtime images at line 209 and eval env images here at line 267), consistent with how other env vars like BUILDKIT_RESET_ON_FAILURE are handled. Good attention to completeness.
…he-mode testing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 19, 2026
Collaborator
Author
|
Closing this PR. At this point we only wish to set non default cache-mode values to swtbench, which is done in this PR #541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-modeworkflow_dispatch input to all 8build-*-images.ymlworkflowsOPENHANDS_BUILDKIT_CACHE_MODEenv var to build stepsmax(preserving existing behavior), acceptsmax,min, oroffThis wires up the SDK's new
OPENHANDS_BUILDKIT_CACHE_MODEenv var (merged in software-agent-sdk#2479) so callers can disable or reduce cache exports when triggering batch image builds via workflow_dispatch.Test plan
cache-mode: offand verify no--cache-toargs in build logsmax) and verify existing behavior is unchanged🤖 Generated with Claude Code