Conversation
All of the build errors I was getting was with the test stuff so I commented it out and hoped it still worked, and it seems to at least for me.
| OPT_VALUE = option; | ||
| } | ||
|
|
||
| public static LightOption getLightOptionFromId(byte id_option) { |
There was a problem hiding this comment.
Use idOption vs id_option, Java uses camelcase
| //LIN - Added light option :D - 18/11/2024 | ||
| short shortData = data.getShort(); // Obtiene el short | ||
| var type = RTLLight.LightType.getLightTypeFromId((byte)shortData); | ||
| System.out.println("Type: " + type); |
| CAST_SHADOW((byte)1), | ||
| HAS_SPECULAR((byte)2), | ||
| UNKNOWN((byte)3), //left in the case we find out unknown light options | ||
| UNK_CLOUDCITY((byte)32); |
There was a problem hiding this comment.
it isnt actually unused. In fact there are multiple cases in which i find unknown light options and in order to add better support in the future I decided to leave it that way so we can explore that (this is also related to the type print thing)
There was a problem hiding this comment.
Ok! In that case it may be worth adding it to the switch statement below
|
|
||
| //var type = RTLLight.LightType.getLightTypeFromId((byte) data.getShort()); | ||
|
|
||
| //LIN - Added light option :D - 18/11/2024 |
There was a problem hiding this comment.
No need for changelog here cause it shows up in the commit
| ANTILIGHT((byte)7), | ||
| JONFLICKER((byte)8); | ||
| JONFLICKER((byte)8), | ||
| CNT((byte)9); |
There was a problem hiding this comment.
its a light type used on bionicle heroes. Its coded as byte 9 and in order to add support for different lighting files (not just the ones we know) i decided to add that there, but i have no clue what it does tbh....
There was a problem hiding this comment.
I'd leave a comment saying that or rename it then
| float distance, | ||
| float falloff, | ||
| float multiplier, | ||
| float d1, |
There was a problem hiding this comment.
Can these be named what the vars mean under this?
There was a problem hiding this comment.
on the properties function you have what they are meant for. In any case, this pull request is actually old. I made some more changes since then and, knowing your requests, i will make some more so you can close the pull request if you want
i still have to experiment a lot with the light option thingy
GizmoPickup SpawnGroup and SpawnType properties
3 participants
Added some more lighting parameters that would improve lighting editing. Also fixed a bug I had when searching the byte that controlled the light option and added an UNKNOWN parameter in case we get to find out unused light options (like it has happened to me on CLOUDCITYESCAPE_A)