-
Notifications
You must be signed in to change notification settings - Fork 61
fix: docs not working for latest version of adaptors in IDE #4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
+ Coverage 89.02% 89.03% +0.01%
==========================================
Files 425 425
Lines 19611 19611
==========================================
+ Hits 17459 17461 +2
+ Misses 2152 2150 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elias-ba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @doc-han for some reasons I still see the error happening.
|
Oh @doc-han I see the issue! This is not your fault at all. Actually what happened was the projectAdaptors list only gets populated from the database - it queries saved jobs to find which adaptors are used in the project. But when you add a new adaptor (like Gmail) to a job and haven't saved yet, that adaptor only exists in the Y.Doc (collaborative state), not in the database. So when your code tried to resolve |
The projectAdaptors list was only populated from the database (saved jobs). When a user added a new adaptor to a job but hadn't saved yet, the adaptor wasn't in projectAdaptors, causing version resolution to fail for docs loading. Fix useProjectAdaptors to merge adaptors from both: 1. Backend DB (saved jobs) 2. Y.Doc state (unsaved jobs in the collaborative editor) This ensures newly added adaptors appear in projectAdaptors immediately, even before saving the workflow.
Description
This PR resolves an issue where the docs panel was unable to retrieve information for some adaptors. mainly the latest versions of the adaptors
Closes #4136
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)