Skip to content

Improve usage #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jh-RLI merged 4 commits into from
Aug 14, 2025
Merged

Improve usage #284

jh-RLI merged 4 commits into from
Aug 14, 2025

Conversation

@maurerle
Copy link
Contributor

@maurerle maurerle commented Aug 11, 2025 •
edited
Loading

Summary of the discussion

  • fix usage of links and docs format
  • add the package itself to list of requirements
  • adjust tooling to generate correct sample files

Type of change (CHANGELOG.md)

Changed

  • update python version and conda env name
  • adjust python generation scripts to match the finalized json

Workflow checklist

Automation

Closes #285
Closes #286

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@jh-RLI
Copy link
Contributor

jh-RLI commented Aug 13, 2025

Thanks for the nice enhancements. It would be good to add your changes to the as we collect everything there not only direct changes to the standard: https://github.com/OpenEnergyPlatform/oemetadata/blob/develop/CHANGELOG.md

And in the section automation (in the PR description above) add the issues numbers (#1234) this PR solves or at least partly solves.
After that we can merge it :)

@maurerle
adjust tooling to generate correct files
d98dba5 
call the scripts using

python oemetadata/v2/v20/build_source/scripts/create_schema.py
python oemetadata/v2/v20/build_source/scripts/create_template.py
python oemetadata/v2/v20/build_source/scripts/create_example.py
@maurerle
Copy link
Contributor Author

maurerle commented Aug 14, 2025

@jh-RLI should be ready now :)

jh-RLI
jh-RLI approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks :)

@jh-RLI jh-RLI merged commit d7457d4 into OpenEnergyPlatform:develop Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build_source scripts do not create exactly the checked in json files Update Python version in instructions to py313

2 participants

@maurerle @jh-RLI