Add comprehensive test suite and fix i18n/config issues

[alexander-acker]

Summary

This PR adds a comprehensive test suite covering core functionality and fixes several issues with internationalization and configuration management.

Key Changes

Test Suite (New Files)

• session-manager-lifecycle.test.ts: Tests for SessionManager lifecycle including session creation, continuation, deletion, and message handling
• store-actions.test.ts: Tests for Zustand store actions covering sessions, messages, trace steps, and UI state management
• database.test.ts: Tests for database initialization, CRUD operations, and schema creation
• config-store.test.ts: Tests for configuration store with provider presets and environment variable application
• memory-manager.test.ts: Tests for memory management including message history, search, and context management
• i18n-completeness.test.ts: Tests ensuring translation completeness between English and Chinese locales
• logger.test.ts: Tests for logging functionality
• credentials-store.test.ts: Tests for credentials storage and retrieval
• session-update.test.ts: Tests for session update utilities

Source Code Fixes

• config-store.ts: Fixed OpenRouter keyHint from Chinese to English ("Get from openrouter.ai/keys")
• session-manager.ts: Added cleanup of pending permissions when deleting a session to prevent memory leaks
• database.ts: Added FTS5 virtual table creation for memory search functionality
• MessageCard.tsx: Added missing useTranslation() hook for proper i18n support
• i18n locales: Added missing sidebar.deleteAllConfirm translation key in both English and Chinese
• Sidebar.tsx: Updated to use i18n translation key instead of hardcoded Chinese string

Notable Implementation Details

• All tests use Vitest with proper mocking of Electron, better-sqlite3, and electron-store modules
• Tests include edge cases like malformed JSON content handling and permission cleanup
• i18n tests verify completeness across locales and catch missing translation keys
• Database tests verify proper schema initialization and index creation
• Store tests validate state management patterns and cleanup operations

https://claude.ai/code/session_01EEkUmHuGJ1mJgB7mqoqTDK

[github-actions]

Findings

• [Blocker] t is referenced inside ContentBlockView without being defined in that component, so this change will fail the renderer build as soon as the new tooltip line is compiled. Evidence src/renderer/components/MessageCard.tsx:167.
  Suggested fix:

  function ContentBlockView(...) {
    const { t } = useTranslation();
    ...
  }

• [Major] deleteSession() now resolves and deletes every entry in pendingPermissions, not just the ones that belong to the session being removed. Deleting one chat can therefore deny tool prompts that are still waiting in other active sessions. Evidence src/main/session/session-manager.ts:614, with the session id only available at insertion time in src/main/session/session-manager.ts:751.
  Suggested fix:

  private pendingPermissions = new Map<
    string,
    { sessionId: string; resolve: (result: PermissionResult) => void }
  >();
  
  this.pendingPermissions.set(toolUseId, { sessionId, resolve });
  
  for (const [toolUseId, pending] of this.pendingPermissions) {
    if (pending.sessionId !== sessionId) continue;
    pending.resolve('deny');
    this.pendingPermissions.delete(toolUseId);
  }

Summary

• Review mode: initial
• 2 issues found: a renderer build break in MessageCard and cross-session permission cancellation in SessionManager.
• Residual testing gap: the new tests do not cover ContentBlockView rendering or a multi-session pending-permission cleanup case.

Testing

• Not run (automation)

Open Cowork Bot

[github-actions]

[BLOCKER] t is only defined in MessageCard, but this new tooltip lives inside ContentBlockView, so the file no longer compiles once this line is added. Please initialize useTranslation() in ContentBlockView (or pass t down explicitly) before using it here.

Suggested fix:

function ContentBlockView(...) {
  const { t } = useTranslation();
  ...
}

[github-actions]

[MAJOR] This loop now denies every pending permission in the process, not only the ones for sessionId. Because requestPermission() stores only the resolver today, deleting one session will also deny tool prompts that are still pending in other live sessions.

Suggested fix:

private pendingPermissions = new Map<
  string,
  { sessionId: string; resolve: (result: PermissionResult) => void }
>();

this.pendingPermissions.set(toolUseId, { sessionId, resolve });

for (const [toolUseId, pending] of this.pendingPermissions) {
  if (pending.sessionId !== sessionId) continue;
  pending.resolve('deny');
  this.pendingPermissions.delete(toolUseId);
}