chore(deps): bump i18next from 25.10.1 to 26.0.8#152
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
There was a problem hiding this comment.
Findings
- [Minor] Major i18next bump has no regression coverage for active count-based translation paths.
Summary
Review mode: initial. One minor issue found: this PR upgrades the runtime translation engine to i18next 26, but there is still no src/tests/ coverage for language switching or the active count-based translation paths that go through it. I did not find a direct API break in the modified lines. Residual risk: pluralization and language-switching behavior remains unverified.
Testing
- Not run (automation)
Open Cowork Bot
| "glob": "^10.3.10", | ||
| "highlight.js": "^11.11.1", | ||
| "i18next": "^25.10.1", | ||
| "i18next": "^26.0.5", |
There was a problem hiding this comment.
[MINOR] This moves the app onto i18next 26, but the repo still has no regression coverage for the runtime paths that depend on count-based translation resolution. Those paths are active in the renderer (src/renderer/components/settings/SettingsConnectors.tsx:399, src/renderer/components/SandboxSyncToast.tsx:95, src/renderer/components/settings/SettingsSchedule.tsx:682), and the locale resources mix singular/plural key shapes (src/renderer/i18n/locales/en.json:416, src/renderer/i18n/locales/zh.json:416). With a major i18n engine bump, that leaves language-switching/pluralization regressions easy to miss.
Suggested fix:
// src/tests/renderer/i18n/config.test.ts
import { createInstance } from 'i18next';
import en from '../../../renderer/i18n/locales/en.json';
import zh from '../../../renderer/i18n/locales/zh.json';
it('keeps count-based translations working after the i18next bump', async () => {
const i18n = createInstance();
await i18n.init({
resources: {
en: { translation: en },
zh: { translation: zh },
},
lng: 'en',
fallbackLng: 'en',
pluralSeparator: '_',
contextSeparator: '_',
});
expect(i18n.t('mcp.toolsAvailable', { count: 2 })).toBe('2 tools available');
await i18n.changeLanguage('zh');
expect(i18n.t('sandbox.syncFiles', { count: 2 })).toBe('2 个文件');
});a8230ab to
208e9f6
Compare
There was a problem hiding this comment.
Review mode: follow-up after new commits
Findings
- [Minor] The i18next 25→26 major bump remains without regression coverage for active count-based translation paths. The previous review (commit a8230ab) flagged this, and the new commits (adding DeepSeek CI scripts) do not address it. Pluralization and language-switching behavior are exercised in the renderer (
src/renderer/components/settings/SettingsConnectors.tsx,src/renderer/components/SandboxSyncToast.tsx,src/renderer/components/settings/SettingsSchedule.tsx) and locale resources (src/renderer/i18n/locales/en.json,zh.json). Without a focused i18next 26 validation test, regressions can slip through unnoticed.
Suggested fix: Add a test like the one proposed in the previous review, confirming thatt('mcp.toolsAvailable', { count: 2 })andt('sandbox.syncFiles', { count: 2 })return the expected strings in both English and Chinese after the upgrade.
Summary
Review mode: follow-up after new commits. The i18next major version bump is still missing regression test coverage. No other issues were introduced by the new commits (DeepSeek CI infrastructure).
Testing
- Not run (automation)
Open Cowork Bot
208e9f6 to
7a68b80
Compare
Bumps [i18next](https://github.com/i18next/i18next) from 25.10.1 to 26.0.8. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v25.10.1...v26.0.8) --- updated-dependencies: - dependency-name: i18next dependency-version: 26.0.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7a68b80 to
60029f0
Compare
Bumps i18next from 25.10.1 to 26.0.8.
Release notes
Sourced from i18next's releases.
... (truncated)
Changelog
Sourced from i18next's changelog.
... (truncated)
Commits
3ea438f26.0.85176bbdretry version bump10b48c626.0.89fdd99aretry version bump9ee7da1changelog8ce5e2626.0.8e802567fix(types): restoreExistsFunctionshape to keep arrow-function wrappers as...ce06fba26.0.7ca33377chore: drop unused@babel/runtimedep and redundant bundled ESM output8abe4e6fix: show resolved plural key in missingKey debug log