chore(deps): bump react-dom and @types/react-dom#149
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
There was a problem hiding this comment.
Findings
- [Blocker]
react-dom19 and@types/react-dom19 are bumped without the matching React 19 runtime/type packages. That leaves the PR head in an unsupported peer state: the lockfile now recordsreact-domrequiringreact: ^19.2.5and@types/react-domrequiring@types/react: ^19.2.0, while the repo still declaresreact18.3.1 and@types/react18.3.12. Evidencepackage.json:89,package.json:108,package-lock.json:4851,package-lock.json:13967.
Suggested fix:{ "dependencies": { "react": "^19.2.5", "react-dom": "^19.2.5" }, "devDependencies": { "@types/react": "^19.2.3", "@types/react-dom": "^19.2.3" } }
Summary
- Review mode: initial. Blocked on aligning the React runtime and type package majors; the current diff upgrades only the DOM half of the stack.
Testing
- Not run (automation)
Open Cowork Bot
| "openai": "^6.32.0", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-dom": "^19.2.5", |
There was a problem hiding this comment.
[BLOCKER] react-dom 19 now peers on react: ^19.2.5, and this PR also moves @types/react-dom to a package that peers on @types/react: ^19.2.0, but the repo is still pinned to react 18.3.1 and @types/react 18.3.12. Please upgrade the matching react/@types/react pair in the same PR, or keep the DOM packages on 18.x.
Suggested fix:
"react": "^19.2.5",
"react-dom": "^19.2.5",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3"6f180cd to
d094cc6
Compare
There was a problem hiding this comment.
Findings
- [Blocker] The previous review flagged that upgrading only
react-domand@types/react-domto v19 without also upgradingreactand@types/reactcreates an unsupported peer dependency state. The new commits in this follow-up (CI infrastructure and review scripts) do not address this issue. Thepackage.jsonstill declares"react": "^18.3.1"and"@types/react": "^18.3.12", while the lockfile recordsreact-dom@19.2.5requiringreact: ^19.2.5and@types/react-dom@19.2.3requiring@types/react: ^19.2.0. This will cause peer dependency warnings or breakage at install time. Evidencepackage.json:89,package.json:108,package-lock.json:14416,package-lock.json:5028.
Suggested fix:{ "dependencies": { "react": "^19.2.5", "react-dom": "^19.2.5" }, "devDependencies": { "@types/react": "^19.2.3", "@types/react-dom": "^19.2.3" } }
Summary
- Review mode: follow-up after new commits. The blocker from the initial review remains unresolved. The added CI scripts and prompt changes are unrelated to the dependency bump and do not mitigate the peer dependency mismatch. The PR must either upgrade
reactand@types/reactto v19 as well, or downgradereact-domand@types/react-domback to 18.x.
Testing
- Not run (automation)
Open Cowork Bot
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.5 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.5/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.2.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
d094cc6 to
fcc3db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.2.5Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
23f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.18618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)Updates
@types/react-domfrom 18.3.7 to 19.2.3Commits