docs: plan Phase 1 discovery and pairing - #25
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds an approved Phase 1 Discovery/Pairing design spec and splits the implementation plan into wave-specific documents (Cave authority, SDK lanes, Chat native connection, and real-authority conformance), while marking the earlier consolidated plan as superseded for implementation details.
Changes:
- Introduces the Phase 1 discovery/pairing “approved design” spec that defines the security boundary and state machine.
- Adds four execution plans (1a–1d) covering Cave authority, SDK discovery/pairing + CLI, Chat native gate, and a packaged real-authority conformance harness.
- Updates the 2026-08-15 consolidated plan with a plan-of-record note pointing implementers at the split plans/spec.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/superpowers/specs/2026-08-20-phase-1-discovery-pairing-design.md | New approved spec defining boundaries, flow, state model, and test strategy for Phase 1. |
| docs/superpowers/plans/2026-08-20-phase-1a-cave-pairing-authority.md | New Cave authority implementation plan (pairing/credentials/auth/discovery/routes/settings/docs). |
| docs/superpowers/plans/2026-08-20-phase-1b-sdk-discovery-pairing.md | New SDK/CLI implementation plan for discovery, pairing, IPC transports, and secret-free outputs. |
| docs/superpowers/plans/2026-08-20-phase-1c-chat-native-connection.md | New Chat plan for native discovery/launch/keychain/transport plus TS gate/controller/tests. |
| docs/superpowers/plans/2026-08-20-phase-1d-real-authority-conformance.md | New plan for a packaged conformance harness + secret scanning + CI wiring and bead closure. |
| docs/superpowers/plans/2026-08-15-phase-1-discovery-pairing.md | Adds a note that the new spec/split plans supersede stale details in this older plan. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+187
to
+193
| async cleanup() { | ||
| for (const pid of trackedChildren) { | ||
| process.kill(pid, 'SIGTERM'); | ||
| cleanedChildren.push(pid); | ||
| } | ||
| cleanupOwnedTempRoot(owned); | ||
| }, |
Comment on lines
+366
to
+368
| steps: | ||
| - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 | ||
| - run: pnpm install --frozen-lockfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review