feat: config bundle export/import + Crashpad minidump capture#79
Merged
Conversation
Config Bundle: - Add config:export-bundle IPC handler (saves .ocbundle, strips apiKey/headers/env) - Add config:import-bundle IPC handler (validates + returns parsed bundle) - Expose exportBundle() / importBundle() via preload context bridge - Declare ConfigBundle type locally until core package is bumped - Wire window.api types in env.d.ts Crashpad: - Call crashReporter.start() before first window so renderer/GPU/main crashes all produce Minidump files on disk - Record crashDumpsDir in stored crash report so users can locate .dmp files - Pass crashDumpsDir to fireTelemetryCrash from render-process-gone handler
f46a78a to
b3cd9f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent improvements:
.ocbundlefile containing provider + MCP server config (secrets stripped).Changes
Config Bundle
packages/desktop/src/main/ipc.tsconfig:export-bundlehandler: shows save dialog for.ocbundle/.json, stripsapiKeyfrom providers andheaders/envfrom MCP servers, writes JSONconfig:import-bundlehandler: shows open dialog, reads + validates the file, returns parsedConfigBundlepackages/desktop/src/preload.tswindow.api.config.exportBundle()andwindow.api.config.importBundle()via context bridgepackages/desktop/src/renderer/env.d.tsconfignamespace typepackages/desktop/src/shared/types.tsConfigBundledeclaration (mirrors core) until@openconduit/coreis bumped to a version that includes itimport typestatements to fiximport/no-duplicateslint warningCrashpad
packages/desktop/src/main.tscrashReporter.start({ submitURL: '', uploadToServer: false })called before the firstBrowserWindowis created — enables Crashpad for renderer, GPU and main processesrender-process-gonehandler now passescrashDumpsDirtofireTelemetryCrashpackages/desktop/src/main/store/settings.tsStoredCrashgains optionalcrashDumpsDir?: stringfieldpackages/desktop/src/main/ipc.tsfireTelemetryCrashaccepts optionalextra: { crashDumpsDir? }and stores it alongside the crash recordContext
Crash that triggered the Crashpad work:
Exit code 5 =
RESULT_CODE_KILLED_BAD_MESSAGE— a native Chromium-level kill with no JS stack trace. Crashpad minidumps are required to diagnose this class of crash.