Skip to content

Conversation

@kletord
Copy link
Contributor

@kletord kletord commented Feb 5, 2025

No description provided.

@kletord kletord requested a review from sidux February 5, 2025 16:07
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Issued by Coverage Checker:

entry = "vendor/phpunit/phpunit/phpunit";
pass_filenames = false;
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to add ecs also (without the auto fix)

@sidux
Copy link
Contributor

sidux commented Feb 5, 2025

since we are impacting all doctrine cache with this, depending on the testing effort planned, we might want to just migrate everything to symfony, (we may have namespace param which is just equal to one tag)

@kletord
Copy link
Contributor Author

kletord commented Feb 6, 2025

since we are impacting all doctrine cache with this, depending on the testing effort planned, we might want to just migrate everything to symfony, (we may have namespace param which is just equal to one tag)

Yes, but in another PR. right it's a bit large ;-)

@kletord kletord merged commit 674f557 into master Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants