Skip to content

Fix not valid variable #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

RomuDeuxfois
Copy link
Member

According to this commit
fbicyber/opencti__opencti@39c382c

The variable to override the openbas API is this one: XTM__OPENBAS_API_OVERRIDE_URL

@labo-flg
Copy link
Member

labo-flg commented Apr 8, 2025

@RomuDeuxfois actually both config variables can be set.
See original issue linked to the PR.
It's abouut being able to differentiate obas links to obas API calls.

@RomuDeuxfois
Copy link
Member Author

Yes, so we have this variable XTM_OPENBAS_URL and this one XTM_OPENBAS_API_OVERRIDE_URL

but not this one XTM__OPENBAS_API_URL

https://github.com/OpenCTI-Platform/opencti/blob/master/opencti-platform/opencti-graphql/src/database/xtm-obas.ts

@aHenryJard
Copy link
Member

Sorry to be picky but can you update the XTM__OPENBAS_URL to "OpenBAS URL that is use to redirect from OpenCTI UI to OpenBas UI" or else I don't think people will understand the difference. (I can't suggest since there is not changes on that line)

@@ -140,7 +140,7 @@ Here are the configuration keys, for both containers (environment variables) and
| Parameter | Environment variable | Default value | Description |
|:--------------------------------|:---------------------------------|:--------------|:-------------------------------------------------------------------------------------------------------------|
| xtm:openbas_url | XTM__OPENBAS_URL | | OpenBAS URL |
| xtm:openbas_api_url | XTM__OPENBAS_API_URL | | If sets, overrides the API base URL used for the OpenBAS integration |
| xtm:openbas_api_override_url | XTM__OPENBAS_API_OVERRIDE_URL | | If sets, overrides the API base URL used for the OpenBAS integration |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| xtm:openbas_api_override_url | XTM__OPENBAS_API_OVERRIDE_URL | | If sets, overrides the API base URL used for the OpenBAS integration |
| xtm:openbas_api_override_url | XTM__OPENBAS_API_OVERRIDE_URL | | If sets, overrides the API base URL used for the OpenBAS integration (default is XTM__OPENBAS_URL/api) |

@RomuDeuxfois
Copy link
Member Author

XTM__OPENBAS_API_URL

As I mentioned, I couldn’t find any usage of the XTM__OPENBAS_API_URL variable.
Could you point me to where it’s used in the code? Thanks!

@aHenryJard
Copy link
Member

aHenryJard commented Jul 4, 2025

XTM__OPENBAS_API_URL

As I mentioned, I couldn’t find any usage of the XTM__OPENBAS_API_URL variable. Could you point me to where it’s used in the code? Thanks!

https://github.com/OpenCTI-Platform/opencti/blob/d5e6bcdb67da79f4ea26af53fd71b7dd68683d87/opencti-platform/opencti-graphql/src/database/xtm-obas.ts#L13

There is no "API" it's xtm:openbas_url and xtm:openbas_api_override_url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants