Skip to content

Conversation

UncleRaymondo
Copy link

@UncleRaymondo UncleRaymondo commented Aug 30, 2025

No need to log an error about a URL not returning any screenshots if the configuration value of import_screenshot is set to False.

Proposed changes

  • Added and self.config.import_screenshot != False on Lines 151 and 170 of src/urlscan_enrichment_services/client.py

Related issues

  • None, direct fix.

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

No need to log an error about a URL not returning any screenshots if the configuration value of `import_screenshot` is set to False.
@UncleRaymondo UncleRaymondo changed the title Update client.py [urlscan-enrichment] Update /src/urlscan_enrichment_services/client.py Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant