Skip to content

Conversation

@heditar
Copy link
Contributor

@heditar heditar commented Nov 14, 2025

Proposed changes

  • escaping new line charater in CSV export

Testing Instructions

  1. Export payload with several lines in the description, in the csv fils it should be escaped and appear as one line
    2

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • [] Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@heditar heditar marked this pull request as ready for review November 14, 2025 09:58
@heditar heditar added the filigran team use to identify PR from the Filigran team label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.46%. Comparing base (3ca5039) to head (ee0e43c).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4368      +/-   ##
============================================
- Coverage     49.53%   49.46%   -0.07%     
- Complexity     3582     3625      +43     
============================================
  Files           886      888       +2     
  Lines         26454    26710     +256     
  Branches       1976     2028      +52     
============================================
+ Hits          13103    13212     +109     
- Misses        12561    12704     +143     
- Partials        790      794       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heditar heditar changed the base branch from release/current to master November 14, 2025 13:12
@savacano28 savacano28 changed the title [frontend] escaping new line charater in CSV export [frontend] fix(export): escaping new line charater in CSV export (#4359) Nov 14, 2025
@damgouj damgouj self-requested a review November 19, 2025 07:13
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK for me, just 2 comments:

  • the indentation failed for your js file,
  • it exports only the shown elements but I think it's "normal" today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export of payload list seems off

3 participants