[frontend/backend] feat(scv): assign Security Domains to payloads (#4119) #4335

GaetanSantucci · 2025-10-29T10:18:21Z

[SCV] Add Centralized Security Control Validation View by Security Domains

Proposed changes

Testing Instructions

Step-by-step how to test

Related issues

#4119

Checklist

I consider the submitted work as finished
I tested the code for its functionality
I wrote test cases for the relevant uses case
I added/update the relevant documentation (either on github or on notion)
Where necessary I refactored code to improve the overall quality
For bug fix -> I implemented a test that covers the bug

github-actions · 2025-11-24T09:14:21Z

Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

github-actions · 2025-11-24T09:14:21Z

Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

🐛 Fix domains test

codecov · 2025-11-27T07:31:34Z

Codecov Report

❌ Patch coverage is 68.62745% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.16%. Comparing base (c74da09) to head (e0443dd).
⚠️ Report is 2 commits behind head on release/current.

Files with missing lines	Patch %	Lines
...ain/java/io/openaev/rest/domain/DomainService.java	45.45%	11 Missing and 1 partial ⚠️
...or_contract/output/InjectorContractFullOutput.java	33.33%	4 Missing and 4 partials ⚠️
...aev/rest/payload/service/PayloadUpsertService.java	42.85%	3 Missing and 1 partial ⚠️
...main/java/io/openaev/importer/V1_DataImporter.java	87.50%	2 Missing and 1 partial ⚠️
...est/injector_contract/InjectorContractService.java	76.92%	1 Missing and 2 partials ⚠️
...rc/main/java/io/openaev/rest/domain/DomainApi.java	33.33%	2 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##             release/current    #4335      +/-   ##
=====================================================
+ Coverage              50.10%   50.16%   +0.06%     
- Complexity              3637     3656      +19     
=====================================================
  Files                    896      900       +4     
  Lines                  26569    26671     +102     
  Branches                1989     1998       +9     
=====================================================
+ Hits                   13312    13380      +68     
- Misses                 12458    12482      +24     
- Partials                 799      809      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

openaev-model/src/main/java/io/openaev/database/model/Domain.java

openaev-api/src/main/java/io/openaev/migration/V4_52__Implement_Domains_notion.java

openaev-api/src/main/java/io/openaev/rest/domain/form/DomainBaseInput.java

openaev-api/src/main/java/io/openaev/rest/domain/form/DomainCreateInput.java

openaev-api/src/main/java/io/openaev/rest/domain/DomainService.java

openaev-api/src/main/java/io/openaev/importer/V1_DataImporter.java

openaev-api/src/main/java/io/openaev/migration/V4_52__Implement_Domains_notion.java

openaev-api/src/main/java/io/openaev/rest/domain/DomainService.java

openaev-front/src/admin/components/payloads/Payloads.tsx

openaev-front/src/components/ItemDomains.tsx

openaev-front/src/components/fields/DomainFieldController.tsx

openaev-front/src/utils/lang/es.json

openaev-api/src/main/java/io/openaev/importer/V1_DataImporter.java

...v-api/src/main/java/io/openaev/rest/injector_contract/output/InjectorContractFullOutput.java

openaev-api/src/main/java/io/openaev/rest/payload/form/PayloadCreateInput.java

openaev-api/src/main/java/io/openaev/rest/payload/form/PayloadUpdateInput.java

openaev-front/src/components/ItemDomains.tsx

RomuDeuxfois · 2025-11-28T20:55:59Z

openaev-front/src/components/fields/DomainFieldController.tsx

+      name={name}
+      control={control}
+      render={({ field: { onChange, value }, fieldState: { error } }) => (
+        <>


nitpick: the chevron isn’t needed here

openaev-front/src/admin/components/payloads/PayloadForm.tsx

openaev-front/src/admin/components/common/injects/Injects.tsx

RomuDeuxfois · 2025-11-28T21:17:18Z

openaev-api/src/main/java/io/openaev/rest/payload/service/PayloadUpsertService.java

+    payload.setDomains(
+        input.getDomains() != null
+            ? domainService.upserts(input.getDomains())
+            : Set.of(
+                domainService.upsert(
+                    new Domain(null, "To classify", "#FFFFFF", Instant.now(), null))));


todo Should follow the behavior exists or create. We don't want to upsert an existing domain by a Payload upsert.

RomuDeuxfois · 2025-11-28T21:18:18Z

openaev-api/src/main/java/io/openaev/rest/payload/service/PayloadService.java

+    injectorContract.setDomains(
+        domainService.upserts(
+            Set.of(new Domain(null, "To classify", "#FFFFFF", Instant.now(), null))));


todo: Should follow the behavior exists or create.

RomuDeuxfois · 2025-11-28T21:18:49Z

openaev-api/src/main/java/io/openaev/rest/payload/service/PayloadCreationService.java


    payload.setAttackPatterns(attackPatterns);
    payload.setTags(iterableToSet(tagRepository.findAllById(input.getTagIds())));
+    payload.setDomains(domainService.upserts(input.getDomains()));


todo: Should follow the behavior exists or create.

openaev-api/src/main/java/io/openaev/rest/payload/form/PayloadUpdateInput.java

openaev-api/src/main/java/io/openaev/rest/payload/form/PayloadCreateInput.java

GaetanSantucci added this to the Release 2.1.0 milestone Oct 29, 2025

GaetanSantucci self-assigned this Oct 29, 2025

GaetanSantucci added feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team labels Oct 29, 2025

savacano28 removed the feature use for describing a new feature to develop label Oct 31, 2025

GaetanSantucci force-pushed the issue/4119 branch from 166e622 to 6b77d41 Compare November 18, 2025 09:52

savacano28 changed the title ~~[frontend/backend] SVC Assign Security Domains to payloads #4119~~ [frontend/backend] feat(scv): assign Security Domains to payloads (#4119) Nov 19, 2025

GaetanSantucci force-pushed the issue/4119 branch 5 times, most recently from 11c7193 to f456d07 Compare November 26, 2025 16:14

GaetanSantucci added 16 commits November 26, 2025 17:55

Implement domains

1981d8c

🚧 Implement Domains

ebca9ae

🚧 Add tests

153932b

🚧 Add relation InjectorContract Domain

33c4c8a

🚧 Add relation InjectorContract Domain

1fbe775

🔥 Set api types

b0c60fe

🎨 Add Domain to store

261c4f1

🐛 fix linter

742f88f

🎨 Set domain to payloads component

aac8773

Domains translation key

4687356

🎨 Update payload model and create service for domains

43d6131

🎨 Update payload model and create service for domains

d044c58

🎨 Add display domains to payload

ad1de12

🎨 Add display domains to payload

ffe6945

fix linter

671a39f

🎨 Add domains to duplicate payload

61cb866

GaetanSantucci and others added 5 commits November 26, 2025 17:56

Refactors domain handling to use Sets

e36a678

🐛 Fix domains test

🐛 Fix domain - update Unclassified to To classify

3781545

🐛 Fix test

6d505bc

Fix migration dif

3f5ff5a

Fix Stix test

bff2e27

GaetanSantucci force-pushed the issue/4119 branch from f456d07 to bff2e27 Compare November 27, 2025 07:20

🎨 Add domain to scenario view

1e9921f

GaetanSantucci marked this pull request as ready for review November 27, 2025 08:14

gabriel-peze self-requested a review November 27, 2025 08:17

GaetanSantucci added 2 commits November 27, 2025 09:24

💄 Fix linter

88bda40

translate key

a9f5cf8

RomuDeuxfois reviewed Nov 27, 2025

View reviewed changes

gabriel-peze reviewed Nov 27, 2025

View reviewed changes

RomuDeuxfois reviewed Nov 27, 2025

View reviewed changes

openaev-api/src/main/java/io/openaev/importer/V1_DataImporter.java Outdated Show resolved Hide resolved

RomuDeuxfois reviewed Nov 27, 2025

View reviewed changes

GaetanSantucci added 2 commits November 27, 2025 18:25

Update domains migration

fc9eaa0

🎨 Improve code

08e46c3

EmilieFo17 force-pushed the issue/4119 branch from 2909d57 to 08e46c3 Compare November 28, 2025 16:38

RomuDeuxfois reviewed Nov 28, 2025

View reviewed changes

GaetanSantucci added 4 commits December 1, 2025 22:09

Improve Domains methods

f39abd1

WIP

77c3f9c

wip on domains

d466ff2

Fix some bugs

2646bbd

GaetanSantucci force-pushed the issue/4119 branch from 6280d1b to 2646bbd Compare December 1, 2025 21:10

GaetanSantucci and others added 2 commits December 1, 2025 22:16

Fix linter warning

329fb35

Merge branch 'release/current' into issue/4119

e0443dd

RomuDeuxfois approved these changes Dec 2, 2025

View reviewed changes

GaetanSantucci merged commit 3905cff into release/current Dec 2, 2025
11 checks passed

GaetanSantucci deleted the issue/4119 branch December 2, 2025 10:13

[frontend/backend] feat(scv): assign Security Domains to payloads (#4119) #4335

[frontend/backend] feat(scv): assign Security Domains to payloads (#4119) #4335

Uh oh!

Conversation

GaetanSantucci commented Oct 29, 2025

Proposed changes

Testing Instructions

Related issues

Checklist

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

codecov bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RomuDeuxfois Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RomuDeuxfois Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

RomuDeuxfois Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

RomuDeuxfois Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Nov 27, 2025 •

edited

Loading