Declarative duts_config and DUT collection refactor #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deixx
force-pushed
the
declarative-duts-config
branch
2 times, most recently
from
02c5e86 to
8a82252
Compare
mmichal10
reviewed
Oct 8, 2024
Deixx
force-pushed
the
declarative-duts-config
branch
from
412985d to
eca1479
Compare
Deixx
force-pushed
the
declarative-duts-config
branch
from
eca1479 to
df2cdf5
Compare
mmichal10
reviewed
Oct 8, 2024
Deixx
force-pushed
the
declarative-duts-config
branch
7 times, most recently
from
45988ce to
430ea00
Compare
Deixx
changed the title
Deixx
force-pushed
the
declarative-duts-config
branch
from
7c219f0 to
0814d8c
Compare
On editing duts_config replace configured duts instead of adding all duts from modified config. This allows for both adding and removing duts. Current behavior led to duplicates if config contained old duts in addition to new ones. Signed-off-by: Daniel Madej <[email protected]>
Signed-off-by: Daniel Madej <[email protected]>
Signed-off-by: Daniel Madej <[email protected]>
Signed-off-by: Daniel Madej <[email protected]>
Handle FileNotFoundError (when overwriting config file) Look for DUT only if queue is not empty Signed-off-by: Daniel Madej <[email protected]>
Removed redundant code, clarified lock, added logging for missing DUT config file Signed-off-by: Daniel Madej <[email protected]>
Check if DUT is in use before adding it to queue Prevent duplicated entries in queue Handle faulty config load Signed-off-by: Daniel Madej <[email protected]>
Acquire test and then look for DUT to run it on Signed-off-by: Daniel Madej <[email protected]>
Signed-off-by: Daniel Madej <[email protected]>
With separate collection thread we can get rid of double loop. Signed-off-by: Daniel Madej <[email protected]>
Daemonized and non-daemonized runner will now behave the same after receiving a SIGTERM or SIGINT signal and close all the processes in the process group. The behaviour was different also for Ctrl+C (affected process group) and sending SIGINT through kill command (affected only the main process). Signed-off-by: Daniel Madej <[email protected]>
Deixx
force-pushed
the
declarative-duts-config
branch
from
0814d8c to
c820db1
Compare
Kamoppl
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On editing duts_config replace configured duts
instead of adding all duts from modified config.
This allows for both adding and removing duts.
Current behavior led to duplicates if config contained
old duts in addition to new ones.