Kamilg/fix ioclass stat tests #1597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katlapinka
reviewed
Dec 18, 2024
Kamoppl
force-pushed
the
kamilg/fix_ioclass_stat_tests
branch
from
b6682e1 to
8eb3192
Compare
Kamoppl
force-pushed
the
kamilg/fix_ioclass_stat_tests
branch
from
8eb3192 to
3b1f3f1
Compare
katlapinka
previously approved these changes
Jan 31, 2025
Kamoppl
force-pushed
the
kamilg/fix_ioclass_stat_tests
branch
from
3b1f3f1 to
633e11b
Compare
Deixx
requested changes
Mar 3, 2025
Comment on lines
10
to
25
| from api.cas import casadm | ||
| from api.cas import ioclass_config | ||
| from api.cas.cache_config import CleaningPolicy, CacheMode, CacheLineSize | ||
| from api.cas.cache_config import ( | ||
| CleaningPolicy, | ||
| CacheMode, | ||
| CacheLineSize, | ||
| CacheModeTrait, | ||
| SeqCutOffPolicy, | ||
| ) | ||
| from api.cas.casadm import StatsFilter | ||
| from api.cas.cli_messages import ( | ||
| check_stderr_msg, | ||
| get_stats_ioclass_id_not_configured, | ||
| get_stats_ioclass_id_out_of_range | ||
| get_stats_ioclass_id_out_of_range, | ||
| ) | ||
| from api.cas.ioclass_config import IoClass |
Contributor
There was a problem hiding this comment.
cleanup imports:
from api.cas import casadm and from api.cas.casadm import StatsFilter
from api.cas import ioclass_config and from api.cas.ioclass_config import IoClass - furthermore later in code there is IoClass = ioclass_config.IoClass
Contributor
There was a problem hiding this comment.
While technically this is correct, what I had in mind was importing necessary things from each module (it's like 3 references for each)
Kamoppl
force-pushed
the
kamilg/fix_ioclass_stat_tests
branch
from
633e11b to
07ce616
Compare
Signed-off-by: Kamil Gierszewski <[email protected]>
Kamoppl
force-pushed
the
kamilg/fix_ioclass_stat_tests
branch
from
07ce616 to
f3d84ce
Compare
Deixx
reviewed
Mar 4, 2025
| stat_val.append(cache_stat.dirty.get_value()) | ||
| stat_name = cache_stat | ||
| else: | ||
| for stat_name in cache_stat: |
Contributor
There was a problem hiding this comment.
stat_name is not an accurate variable name
Deixx
reviewed
Mar 4, 2025
| stat_val.append(core_stat.dirty.get_value()) | ||
| stat_name = core_stat | ||
| else: | ||
| for stat_name in core_stat: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.