Method isTripActive able to check the delay cases in StopTimeUpdate

[TsimurSh]

Hi,
Please take a look at this change. Unfortunately, this method will regret all trips and mark them as inactive if the tripUpdates use a delay in the stopTimeUpdate.

[CLAassistant]

All committers have signed the CLA.

[aaronbrethorst]

Thanks for your contribution. Can you elaborate on the scenario you’re solving for and also add tests that validate it?

[TsimurSh]

Ok. I added a test.
Problems what it solve:
In normal GTFS-realtime updates, trip predictions are considered active if:

• There’s at least one stop time update,
• And its first and last stop predictions fall within a valid time window.
  But sometimes a TripUpdate:
• Lacks timestamps (i.e., no arrival.time),
• Only has a delay

The previous logic would fail in such a case because it relies on arrival/departure time values.

@aaronbrethorst Take a look at.

[Copilot]

Pull Request Overview

This PR addresses an issue in the Trip Library where trips with a delay (but without an arrival time) are being incorrectly marked as inactive.

• Adds a new test (testIsTripActive_WithDelayNoTimeAndScheduledTrip) to validate that trips with a delay and scheduled status are active.
• Exposes the isTripActive method via a new public getter (getIsTripActive) to facilitate testing.
• Updates the isTripActive method to return true when the last stop time has a delay and no time with a scheduled trip.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
onebusaway-transit-data-federation/src/test/java/org/onebusaway/transit_data_federation/impl/realtime/gtfs_realtime/GtfsRealtimeTripLibraryTest.java	Added a new unit test to validate delay without time handling for scheduled trips.
onebusaway-transit-data-federation/src/main/java/org/onebusaway/transit_data_federation/impl/realtime/gtfs_realtime/GtfsRealtimeTripLibrary.java	Exposed the isTripActive method and updated its logic to check delay cases correctly.