Skip to content

Allow the boot error suppression to be configured - #59

Open
BenHetherington wants to merge 3 commits into
OffBroadway:custom-loader-menufrom
BenHetherington:configurable-boot-error-suppression
Open

Allow the boot error suppression to be configured#59
BenHetherington wants to merge 3 commits into
OffBroadway:custom-loader-menufrom
BenHetherington:configurable-boot-error-suppression

Conversation

@BenHetherington

Copy link
Copy Markdown

Previously, Cubeboot would always suppress error messages on boot relating to settings and the RTC. This gives the user option to leave these error messages in place, if they wish to be informed when their SRAM battery has lost power.

Additionally, this patches the calls that determines if an error has occurred, rather than the resulting menu state – this allows it to use the same code path as normal, setting the menu state depending on if bs2tick reports that the disc cover’s open.

Previously, Cubeboot would always suppress error messages on boot relating to settings and the RTC. This gives the user option to leave these error messages in place, if they wish to be informed when their SRAM battery has lost power.

Additionally, this patches the calls that determines if an error has occurred, rather than the resulting menu state – this allows it to use the same code path as normal, setting the menu state depending on if `bs2tick` reports that the disc cover’s open.
Comment thread cubeboot/source/settings.c Outdated
@trevor403

Copy link
Copy Markdown
Member

TBD please resolve conflict and I will review

…ssion

# Conflicts:
#	patches/linker/link_ntsc10.ld
#	patches/linker/link_ntsc11.ld
#	patches/linker/link_ntsc12_001.ld
#	patches/linker/link_ntsc12_101.ld
#	patches/linker/link_pal10.ld
#	patches/linker/link_pal11.ld
#	patches/linker/link_pal12.ld
#	patches/source/main.c
This seems like a more concise description of what the setting is, compared to the previous `suppress_boot_setup_and_rtc_errors`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants