Remove Deprecated notice with empty field description#789
Open
Ilya-Zhulin wants to merge 2 commits intoOctopoos:masterfrom
Open
Remove Deprecated notice with empty field description#789Ilya-Zhulin wants to merge 2 commits intoOctopoos:masterfrom
Ilya-Zhulin wants to merge 2 commits intoOctopoos:masterfrom
Conversation
This `trim` isn't really needed here, but PHP 8+ shows a message like ```Deprecated: trim(): Passing null to parameter Octopoos#1 of type string is deprecated``` when field description is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
trimisn't really needed here, but PHP 8+ shows a message likeDeprecated: trim(): Passing null to parameter #1 of type string is deprecatedwhen field description is empty.trimwill be applied in next string without any problems.