Skip to content

Update date.php#278

Open
denysdesign wants to merge 1 commit intoOctopoos:masterfrom
denysdesign:patch-2
Open

Update date.php#278
denysdesign wants to merge 1 commit intoOctopoos:masterfrom
denysdesign:patch-2

Conversation

@denysdesign
Copy link
Copy Markdown
Contributor

Replace strtolower() to JString::strtolower()

@sebastienheraud sebastienheraud added this to the SEBLOD 3.12.0 milestone Nov 10, 2016
@sebastienheraud
Copy link
Copy Markdown
Member

Hi,
Thanks for the report.
This will need to be changed/checked across ALL Core/More/Vip/Labs extensions.
And I guess we'll use directly use Joomla\String\StringHelper
Saba.

@Dgikar
Copy link
Copy Markdown

Dgikar commented Jan 11, 2019

Not JString::strtolower. StringHelper::strtolower - Read these

How to make sure that the correct meaning is displayed in the Russian and Ukrainian languages:

  • One minutE (одна минутА (rus) / одна хвилинА (ukr))
  • Two minutES (две минутЫ (rus) / дві хвилинИ (ukr))
  • Three minutES (три минутЫ (rus) / три хвилинИ (ukr))
  • Four minutES (четыре минутЫ (rus) / чотири хвилинИ (ukr))
  • Five minutES (пять минуТ (rus) / п'ять хвилиН (ukr))
  • ....
  • One houR (один чаС (rus) / одна годинА (ukr))
  • Two houRS (два часА (rus) / дві годинИ (ukr))
  • Three houRS (три часА (rus) / три годинИ (ukr))
  • Four houRS (четыре часА (rus) / чотири годинИ (ukr))
  • Five houRS (пять часОВ (rus) / п'ять годиН (ukr))
  • ....

There are just two concepts in English: minutE and minutES, and in Russian and Ukrainian - three:

  • One minutE (одна минутА (rus) / одна хвилинА (ukr))
  • Two minutES (две минутЫ (rus) / дві хвилинИ (ukr))
  • Five minutES (пять минуТ (rus) / п'ять хвилиН (ukr))

as well as in English: houR and houRS, and in Russian and Ukrainian - three:

  • One houR (один чаС (rus) / одна годинА (ukr))
  • Two houRS (два часА (rus) / дві годинИ (ukr))
  • Five houRS (пять часОВ (rus) / п'ять годиН (ukr))
  • ....

@sebastienheraud
Copy link
Copy Markdown
Member

sebastienheraud commented Mar 28, 2019

Hi,

Thanks for the input. We should be able to move forward on this one as we'll be working on a "cyrillic" website in the upcoming weeks.

Sebastien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants