Update date.php#278
Open
denysdesign wants to merge 1 commit intoOctopoos:masterfrom
denysdesign:patch-2
Open
Conversation
Member
|
Hi, |
|
Not JString::strtolower. StringHelper::strtolower - Read these How to make sure that the correct meaning is displayed in the Russian and Ukrainian languages:
There are just two concepts in English: minutE and minutES, and in Russian and Ukrainian - three:
as well as in English: houR and houRS, and in Russian and Ukrainian - three:
|
Member
|
Hi, Thanks for the input. We should be able to move forward on this one as we'll be working on a "cyrillic" website in the upcoming weeks. Sebastien |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace strtolower() to JString::strtolower()