Make behaviour of Trust Boundary Boxes more reasonable#1724
Draft
boomer41 wants to merge 2 commits into
Draft
Conversation
Collaborator
|
This is a change to the behavior of the trust boundary boxes and needs discussion and thinking through, so putting ths pull request into draft The existing trust boundary box behavior is as designed / expected, but I understand totally that it is difficult to suit every user, hence discussion is needed before a silent change like this is introduced |
|
This PR is stale because it has been open 21 days with no activity. Remove stale label, or add a comment, otherwise it will be closed in 7 days |
Collaborator
Author
|
bad bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1723.
Split from #1718
When accidentally mis-clicking to an empty space, the box gets selected.
To un-select it I have to scroll to somewhere where the box is not, click on an empty space, and return.
I can not select any other node inside the box until the box is deselected.
Additionally, the left margin of the box label seems a bit "random".
It is somehow floating, but not centered nor fixed to any edge.
Description for the changelog:
Declaration:
Thanks for submitting a pull request, please make sure:
[e.g. GitHub CoPilot, ChatGPT, JetBrains Junie, etc][e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro, etc][Summarize the key prompts or instructions given to the AI tools]Other info: