Merged
Conversation
Removed 5 empty scaffold-generated spec files that provided no value: - spec/helpers/api/v1/users_helper_spec.rb - spec/helpers/password_resets_helper_spec.rb - spec/helpers/pay_helper_spec.rb - spec/models/pay_spec.rb - spec/views/password_resets/new.html.erb_spec.rb These files were: - Entirely commented out with Rails scaffold boilerplate - Contained no actual tests - Not referenced in wiki or documentation - Testing empty helper modules with no functionality This cleanup removes the last instances of commented-out `pending` statements found by git grep "pending " and reduces test file clutter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
I think this is what @jasnow was saying:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 5 empty Rails scaffold-generated spec files that provide no value to the codebase.
Context
Following up on the RSpec
pendingcleanup (#495), @jasnow rangit grep "pending "and found these files still contained commented-outpendingstatements. Upon investigation, these files were entirely Rails scaffold boilerplate with no actual tests.Files Removed
spec/helpers/api/v1/users_helper_spec.rbspec/helpers/password_resets_helper_spec.rbspec/helpers/pay_helper_spec.rbspec/models/pay_spec.rbspec/views/password_resets/new.html.erb_spec.rbWhy Remove These?
pendingstatements were commented with#Verification
✅ Verified helpers exist but are empty:
app/helpers/users_helper.rb- empty moduleapp/helpers/password_resets_helper.rb- empty moduleapp/helpers/pay_helper.rb- empty module✅ Verified no references in:
This completes the cleanup of commented
pendingstatements found bygit grep "pending ".🤖 Generated with Claude Code