Skip to content

Remove empty Rails scaffold spec files#496

Merged
cktricky merged 1 commit intomainfrom
chore/remove-empty-scaffold-specs
Jan 6, 2026
Merged

Remove empty Rails scaffold spec files#496
cktricky merged 1 commit intomainfrom
chore/remove-empty-scaffold-specs

Conversation

@cktricky
Copy link
Contributor

@cktricky cktricky commented Jan 6, 2026

Summary

Removes 5 empty Rails scaffold-generated spec files that provide no value to the codebase.

Context

Following up on the RSpec pending cleanup (#495), @jasnow ran git grep "pending " and found these files still contained commented-out pending statements. Upon investigation, these files were entirely Rails scaffold boilerplate with no actual tests.

Files Removed

  • spec/helpers/api/v1/users_helper_spec.rb
  • spec/helpers/password_resets_helper_spec.rb
  • spec/helpers/pay_helper_spec.rb
  • spec/models/pay_spec.rb
  • spec/views/password_resets/new.html.erb_spec.rb

Why Remove These?

  1. Entirely commented out - All code including pending statements were commented with #
  2. No tests - Just Rails scaffold boilerplate saying "add some examples or delete this file"
  3. Testing empty modules - The helpers being tested are empty modules with no functionality
  4. Not referenced - Verified not referenced in wiki, gh-pages, or any documentation
  5. Reduces clutter - Removes 60 lines of unused scaffold code

Verification

✅ Verified helpers exist but are empty:

  • app/helpers/users_helper.rb - empty module
  • app/helpers/password_resets_helper.rb - empty module
  • app/helpers/pay_helper.rb - empty module

✅ Verified no references in:

  • Wiki documentation
  • gh-pages website
  • Main codebase

This completes the cleanup of commented pending statements found by git grep "pending ".

🤖 Generated with Claude Code

Removed 5 empty scaffold-generated spec files that provided no value:
- spec/helpers/api/v1/users_helper_spec.rb
- spec/helpers/password_resets_helper_spec.rb
- spec/helpers/pay_helper_spec.rb
- spec/models/pay_spec.rb
- spec/views/password_resets/new.html.erb_spec.rb

These files were:
- Entirely commented out with Rails scaffold boilerplate
- Contained no actual tests
- Not referenced in wiki or documentation
- Testing empty helper modules with no functionality

This cleanup removes the last instances of commented-out `pending`
statements found by git grep "pending " and reduces test file clutter.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@cktricky
Copy link
Contributor Author

cktricky commented Jan 6, 2026

I think this is what @jasnow was saying:

git grep "pending "

@cktricky cktricky merged commit 757262b into main Jan 6, 2026
8 checks passed
@cktricky cktricky deleted the chore/remove-empty-scaffold-specs branch January 6, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant