Fix ERROR-level basedpyright type checking issues - #313
Closed
shivachethanreddy wants to merge 1 commit into
Closed
shivachethanreddy wants to merge 1 commit into
shivachethanreddy wants to merge 1 commit into
Conversation
izar
pushed a commit
that referenced
this pull request
May 21, 2026
Applies the valid type fixes from #313, dropping changes that were superseded by the Pydantic refactor in #320. Applied: - flows.py: Fix req_reply return type annotation ((DF, DF) → tuple[DF, DF]) and reply return type (DF → tuple[DF, DF]) - template_engine.py: Rename format_field parameter spec → format_spec to match string.Formatter base class signature - pytm.py: Import PydanticUndefined from pydantic_core instead of the private pydantic.fields module - tm.py: Declare _duplicate_ignored_attrs as a ClassVar rather than monkey-patching it at module level Dropped (no longer applicable): - varBool string-to-bool coercion — varBool is now a plain type alias; Pydantic handles coercion - DataSet.__str__ None guard — DataSet was rewritten in #320 with a _names index that is already safe - DataSet generic type parameterization — superseded by the new DataSet implementation in base.py *Tests* All tests passing, no additional code coverage needed.
Collaborator
|
Applied on #322, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes ERROR-level issues reported by basedpyright / pyright.
Changes include:
All fixes were verified locally using basedpyright.
Warnings were intentionally left out of scope.
No runtime behavior or API changes were made.