Repository navigation
tests: Give pytest.approx one coordinate pair at a time - #8120
Merged
Merged
Conversation
pytest 9.2.0 rejects nested containers in pytest.approx(). Before, a list of tuples was accepted but each tuple was compared exactly, so the tolerance was never applied. Compare each pair with its own approx.
github-actions
Bot
added
vector
echoix
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 9.2.0 raises
TypeErrorfor any nested container inpytest.approx()(pytest-dev/pytest#10210). Two tests pass a list of coordinate pairs and now fail in CI on all platforms:vector/v.proj/tests/v_proj_test.py::test_smax_zero_matches_per_vertex_pathlib/cluster/tests/lib_cluster_exec_ctypes_test.py::test_exec_separates_two_well_separated_groupsBefore 9.2.0 such a list was accepted, but each tuple was compared exactly, so the tolerance was never applied. These now compare each pair with its own
pytest.approx().This is the CI failure seen in #8116 and other open PRs.
Tested in the
osgeo/grass-gis:main-alpineimage: both test files pass with pytest 9.1.1 before and after, and with 9.2.0 the two tests fail on main and pass with this change. I also checked that the new form passes a 1e-6 difference and fails a real one.Diagnosed and implemented with the help of Claude Code.