Skip to content

wxGUI: Fix split stdout lines and hidden console messages - #8038

Merged
petrasovaa merged 5 commits into
OSGeo:mainfrom
saket0187:wxgui-console-stdout-lines
Nov 5, 2026
Merged

petrasovaa merged 5 commits into
OSGeo:mainfrom
saket0187:wxgui-console-stdout-lines

Conversation

@saket0187

Copy link
Copy Markdown
Contributor

Follow-up to #8005: GStdout now keeps lines whole like GStderr (long tool output, e.g. r.out.ascii rows, was split into several lines).
The other 9 files add the missing \n to some messages (3D view, region, settings, ...), which since #8005 stayed hidden until later output.
@petrasovaa

@github-actions github-actions Bot added GUI wxGUI related Python Related code is in Python labels Oct 9, 2026

@echoix echoix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for placing the extra new line outside the translated strings, they are a little pain to translate as trailing characters like these are not visible, and if you would have added them there, it would have invalidated the translation in each of the languages, if it was already there

@saket0187

Copy link
Copy Markdown
Contributor Author

@petrasovaa Are any changes needed here?

Comment thread gui/wxpython/core/gconsole.py Resolved
@saket0187
saket0187 requested a review from petrasovaa October 22, 2026 07:30
@saket0187

Copy link
Copy Markdown
Contributor Author

@petrasovaa, is anything else needed here?

@petrasovaa petrasovaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is good to go

@petrasovaa
petrasovaa enabled auto-merge (squash) November 5, 2026 03:35
@petrasovaa
petrasovaa merged commit aca52e2 into OSGeo:main Nov 5, 2026
26 checks passed
@github-actions github-actions Bot added this to the 8.6.0 milestone Nov 5, 2026
@saket0187
saket0187 deleted the wxgui-console-stdout-lines branch November 5, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI wxGUI related Python Related code is in Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants