build: prepare for FHS, where GISBASE is not the absolute truth #5630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI
nilason
force-pushed
the
fix_cmake_share_dir
branch
from
5acbd05 to
518072c
Compare
marisn
reviewed
May 19, 2025
general/g.mkfontcap/Makefile
Outdated
| @@ -17,6 +17,7 @@ default: cmd $(CAPFILE) | |||
| endif | |||
|
|
|||
| $(CAPFILE): $(BIN)/$(PGM)$(EXE) | |||
| GISRC=junk GISBASE=$(RUN_GISBASE) \ | |||
| GISRC=junk GISBASE=$(RUN_GISBASE) GRASS_SHARE_DIR=$(RUN_GISBASE) \ | |||
| GRASS_LOCALEDIR=$(RUN_GISBASE)/locale \ | |||
There was a problem hiding this comment.
Why GRASS_LOCALEDIR and GRASS_SHARE_DIR?
nilason
force-pushed
the
fix_cmake_share_dir
branch
from
a999682 to
91955b8
Compare
nilason
force-pushed
the
fix_cmake_share_dir
branch
from
91955b8 to
d852aef
Compare
nilason
added a commit
to nilason/grass
that referenced
this pull request
Jun 21, 2025
(This is extracted from OSGeo#5630 to simplify review.) The transitional period from the traditional GRASS installation structure to a Filesystem Hierarchy Standard (FHS) complying structure (enabled by CMake build) requires an alternative way to find resources. Currently all resources are located in relation to GISBASE, that is no longer the case with a FHS installation. In addition, and instead of GISBASE, the following environment variables will be needed (not included in this update): - GRASS_SHAREDIR - GRASS_LOCALEDIR - GRASS_PYDIR - GRASS_GUIWXDIR - GRASS_GUISCRIPTDIR - GRASS_GUIRESDIR - GRASS_FONTSDIR - GRASS_ETCDIR Setting up all these variables would bloat the grass.py file, therefore this update suggests to move this to the grass.app Python module. Summary of changes: - grass.py: to simplify Conda adoption, the variable GRASS_PREFIX is added, which is essentially equal to installation prefix, but easily changeable if needed. - grass.py need to find the Python module to be able to set necessary variables, a new variable GRASS_PYDIR is configured into the file to do just this. - python/grass/app/resource_paths.py is a configurable file (like grass.py) - update copy_python_files_in_subdir.cmake to be able to exclude files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GISBASEis used as a means to retrieve paths to various resources in source code. With FHS (#3661) this is no longer possible. This adds a number of new environment variables to address this.Currently this is addressed with following workaround:
grass/CMakeLists.txt
Lines 176 to 194 in 5e998d3
This is work in progress.