Conversation
There was a problem hiding this comment.
💡 Codex Review
oda_reader/src/oda_reader/_cache/config.py
Lines 12 to 14 in 406c23c
The package version was bumped to 1.3.1 in pyproject.toml, but __version__ in the cache configuration remains hardcoded to "1.3.0". get_cache_dir() incorporates this string into the cache path to force invalidation on upgrades. Leaving it at 1.3.0 means users installing 1.3.1 will continue using the old ~/.cache/oda-reader/1.3.0/ directory, so stale HTTP/DataFrame caches persist and the new filesystem cache backend introduced here won’t be isolated from the previous release.
oda_reader/src/oda_reader/common.py
Lines 115 to 118 in 406c23c
The updated documentation now states the client limits to 20 requests per hour, but the code still initializes RateLimiter with max_calls=20 in a 60‑second period and the global API_RATE_LIMITER uses those defaults. With no change here the library continues to allow up to 1200 calls per hour, which will violate a 20/hour API quota and trigger rate-limit errors. Either the constructor defaults or the docs need to be updated so throttling matches the documented limit.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This pull request focuses on improving the documentation for ODA Reader, clarifying usage instructions, updating schema/version fallback examples, and streamlining advanced usage and performance guidance. It also includes a new changelog entry for version 1.3.1, reflecting improved cache management and documentation. The most significant changes are grouped below.
Documentation Updates and Clarifications
Performance and Bulk Download Guidance
Installation and Usage Instructions
uv add oda-readerinstead ofuv pip install oda-readerfor clarity.General and Schema Translation Improvements
Changelog