-
Notifications
You must be signed in to change notification settings - Fork 165
Configuration driven device and scene definitions. #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks, @adam-marek , for this PR. It looks really promising. Please give me some time to look through all of this. Currently I am a little bit busy ... |
|
No worries, take your time. In general I view these changes as the first step towards having OMOTE configurable via a web/desktop app. We just need the app to spit out the YAML config which then could be pulled into OMOTE at runtime (over MQTT, http, etc.) instead of having it compiled into the binary. BTW, I saw some CI failures above which resulted from PlatformIO not having the PyYAML package in its standard environment - just added automated install for that package. |
|
Added conditional compilation for config sources so that the legacy configuration (no YAML_CONFIG defined) still compiles with the config dependencies missing. |
|
The mingw64 fail above does not seem related to my changes .... |
|
No, not related to your changes. The way the action has to be defined changed. I fixed it in main, but in your branch it is still the old way, which fails. But you can ignore it, since the other builds are successful. |
See https://github.com/amarek/OMOTE-Firmware/blob/config/config.md for description of the changes.