Skip to content

Fix value_as_concept_id missing from CTE when Measurement abnormal=true#233

Open
YaroslavTir wants to merge 1 commit intoOHDSI:masterfrom
odysseusinc:measurement-abnormal-cte-column
Open

Fix value_as_concept_id missing from CTE when Measurement abnormal=true#233
YaroslavTir wants to merge 1 commit intoOHDSI:masterfrom
odysseusinc:measurement-abnormal-cte-column

Conversation

@YaroslavTir
Copy link
Copy Markdown
Contributor

@YaroslavTir YaroslavTir commented Feb 23, 2026

Bug

When abnormal=true is set without explicit concept values, the generated SQL fails with column c.value_as_concept_id does not exist. The column was only added to the CTE SELECT when valueAsConcept or valueAsConceptCS was set, but the abnormal WHERE clause always references it.

Before

select
  m.person_id, m.measurement_id, m.measurement_concept_id,
  m.visit_occurrence_id, m.value_as_number,
  m.range_high, m.range_low,
  -- ❌ value_as_concept_id missing
  m.measurement_date as start_date, ...
WHERE (C.value_as_number < C.range_low or C.value_as_number > C.range_high
  or C.value_as_concept_id in (4155142, 4155143))  -- ❌ column doesn't exist

After

select
  m.person_id, m.measurement_id, m.measurement_concept_id,
  m.visit_occurrence_id, m.value_as_number,
  m.range_high, m.range_low, m.value_as_concept_id,  -- ✅ now included
  m.measurement_date as start_date, ...
WHERE (C.value_as_number < C.range_low or C.value_as_number > C.range_high
  or C.value_as_concept_id in (4155142, 4155143))  -- ✅ works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant