-
Notifications
You must be signed in to change notification settings - Fork 19
update ocrd_kraken #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ocrd_kraken #288
Conversation
|
Note: CI stops short due to a CircleCI syntax error ( |
Did you merge the fix in master back to this branch? I did for your |
|
What about OCR-D/ocrd_kraken#33? I think we should require kraken 3.0.9 or even 4.0. |
|
Maybe PR #297 which also touches the Makefile rules for |
I don't understand your question. This PR sets ocrd_kraken to PR 33, which already requries
No, it's the other way round. This PR is minimal and has been hanging here for one month already. |
To bring it to the point: this PR breaks some build configurations which no longer work when it is applied. I only suggested to fix that before the PR is merged instead of first breaking and then fixing. |
You mean Python 3.10? That can wait. Users should finally have ocrd_kraken back. Merging is on your side. |
Even if still PR, the newer ocrd_kraken is already usable and therefore should be re-activated.
(Note: will probably work even better after applying the recent suggestions and updating here again.)