warn if bitcoind is still in IBD #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
reviewed
Jul 7, 2025
luke-jr
reviewed
Jul 7, 2025
luke-jr
requested changes
Jul 14, 2025
src/datum_blocktemplates.c
Outdated
| // fetch latest template | ||
| snprintf(gbt_req, sizeof(gbt_req), "{\"method\":\"getblocktemplate\",\"params\":[{\"rules\":[\"segwit\"]}],\"id\":%"PRIu64"}",(uint64_t)((uint64_t)time(NULL)<<(uint64_t)8)|(uint64_t)(i&255)); | ||
| gbt = bitcoind_json_rpc_call(tcurl, &datum_config, gbt_req); | ||
| gbt = bitcoind_json_rpc_call(tcurl, &datum_config, gbt_req, 0); |
Contributor
There was a problem hiding this comment.
If we're not going to set FAILONERROR, we should be checking the return code here somewhere instead
Member
Author
There was a problem hiding this comment.
That's what I do below?
if ((int)json_integer_value(code_val) == -10) {
Member
Author
There was a problem hiding this comment.
I'm looking for a way to not touch FAILONERROR but there is something I don't understand, why do datum return the HTTP code 500 while curl ... -w "%{http_code}\n" return 200 on the same syncing node?
2025-08-27 15:12:59.975 [ json_rpc_call_full] DEBUG: JSON decode failed(-1): wrong arguments
2025-08-27 15:12:59.975 [ datum_gateway_template_thread] ERROR: Could not fetch new template from http://localhost:8332!
2025-08-27 15:13:01.102 [ json_rpc_call_full] DEBUG: json_rpc_call: HTTP request failed: The requested URL returned error: 500
2025-08-27 15:13:01.102 [ json_rpc_call_full] DEBUG: json_rpc_call: Request was: {"method":"getblocktemplate","params":[{"rules":["segwit"]}],"id":449614740504}
curl --user <user> --data-binary '{"jsonrpc": "2.0", "id": "curltest", "method": "getblocktemplate", "params": [{"rules": ["segwit"]}]}' -H 'content-type: application/json' http://127.0.0.1:8332/ -w "%{http_code}\n"
Enter host password for user '<user>': <password>
{"jsonrpc":"2.0","error":{"code":-10,"message":"Bitcoin Knots is in initial sync and waiting for blocks..."},"id":"curltest"}
200
src/datum_jsonrpc.h
Outdated
| bool update_rpc_cookie(global_config_t *cfg); | ||
| void update_rpc_auth(global_config_t *cfg); | ||
| json_t *bitcoind_json_rpc_call(CURL *curl, global_config_t *cfg, const char *rpc_req); | ||
| json_t *bitcoind_json_rpc_call(CURL *curl, global_config_t *cfg, const char *rpc_req, int failonerror); |
Contributor
There was a problem hiding this comment.
If it makes sense to pass failonerror (IMO it doesn't), it should be a bool
Member
Author
There was a problem hiding this comment.
Why? that an easy way to not affect other call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be very usefull for the upcoming datum-gateway package for the debian official package distribution.