Skip to content

[18.0][MIG] stock_picking_report_qty_undelivered: Migration to 18 #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Andrii9090 wants to merge 4 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] stock_picking_report_qty_undelivered: Migration to 18 #463

Andrii9090 wants to merge 4 commits into from
+1,009 −0

Conversation

@Andrii9090
Copy link

@Andrii9090 Andrii9090 commented Jan 8, 2026 •
edited
Loading

@Andrii9090 Andrii9090 marked this pull request as draft January 8, 2026 10:50
@Andrii9090 Andrii9090 marked this pull request as ready for review January 8, 2026 10:53
Shide
Shide approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

yajo
yajo approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

chienandalu
chienandalu approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Functional and code review 👍

https://www.loom.com/share/480949ce3990493ea7a6b7c371d71621

fcvalgar
fcvalgar approved these changes Jan 9, 2026
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations @Andrii9090, and thank you for your valuable contribution to this improvement.

The following functional tests have been performed:

Test 1: Operation type configuration flag is available and can be enabled (OK)
Test 2: Partial delivery with No backorder prints the undelivered quantity summary on the delivery slip (OK)
Test 3: Undelivered quantity summary is not printed when the operation type flag is disabled (OK)
Test 4: Full delivery shows the informational message indicating that all quantities have been delivered (OK)
Test 5: Undelivered quantity summary applies only to operation types with the flag enabled (OK)

Thank you @Andrii9090 for

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@yajo yajo yajo approved these changes

@Shide Shide Shide approved these changes

@chienandalu chienandalu chienandalu approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Andrii9090 @yajo @Shide @chienandalu @fcvalgar @OCA-git-bot @EmilioPascual @mymage @Xino61122