-
-
Notifications
You must be signed in to change notification settings - Fork 272
[19.0][MIG] stock_picking_report_valued: Migration to 19.0 #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
[19.0][MIG] stock_picking_report_valued: Migration to 19.0 #453
Conversation
For avoiding problems if you don't have access to sales orders (stricter warehouse users, inter-company records...).
- This commit odoo/odoo@41bea41 breaked the inheritance.
In certain conditions of the DB (i.e. integration tests), previous code doesn't assure the price is going to be 100.
[FIX] stock_picking_report_valued: Wrong taxes amount if round globally (OCA#56) [FIX] stock_picking_report_valued: Remove round_method condition because don't apply here [FIX] stock_picking_report_valued: price_reduce is stored with product decimal precision [FIX] stock_picking_report_valued: division_by_zero when unrelated sale order [FIX] stock_picking_report_valued: Improve code [FIX] stock_picking_report_valued: Multiple taxes in sale line (WIP)
…ferences TT17492 TT26034 TT33957 TT34954
The fix in fac3997 didn't consider move lines without a linked sale line. That would end up in inconsistent calculations and even the original line rewriting. TT38863
- In standard report, Odoo always show qty_done
…ots in delivery slip
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/pt/
Currently translated at 73.9% (17 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/fr_FR/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/it/
Currently translated at 100.0% (22 of 22 strings) Translation: stock-logistics-reporting-17.0/stock-logistics-reporting-17.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-17-0/stock-logistics-reporting-17-0-stock_picking_report_valued/it/
We make sure that the currency_id field always has a value to avoid errors. For example, when installing this module with stock_picking_report_delivery_cost and running the tests, there is a case where the picking has no currency defined, which blocks the CI.
|
/ocabot migration stock_picking_report_valued Please take into account #450 |
|
@pedrobaeza this is added |
cf054f1 to
198f1a2
Compare
Reyes4711-S73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This PR has the |
198f1a2 to
2aead4a
Compare
The way the fields were calculated has been modified, since after performing the new() function, it recalculates the fields and loses them, only showing the unit price at the end. Therefore, it has been modified so that if it has a quantity different from the sales order or a different UOM, it first calculates the subtotal price and then performs the new() function. This way, the prices are calculated correctly in the report and the lines.
2aead4a to
3d34d01
Compare
Module migrated to version 19.0