Skip to content

Conversation

@arantxa-s73
Copy link

Module migrated to version 19.0

Luis M. Ontalba and others added 30 commits November 19, 2025 15:01
For avoiding problems if you don't have access to sales orders (stricter
warehouse users, inter-company records...).
In certain conditions of the DB (i.e. integration tests), previous code doesn't assure
the price is going to be 100.
[FIX] stock_picking_report_valued: Wrong taxes amount if round globally (OCA#56)

[FIX] stock_picking_report_valued: Remove round_method condition because don't apply here

[FIX] stock_picking_report_valued: price_reduce is stored with product decimal precision

[FIX] stock_picking_report_valued: division_by_zero when unrelated sale order

[FIX] stock_picking_report_valued: Improve code

[FIX] stock_picking_report_valued: Multiple taxes in sale line (WIP)
The fix in fac3997 didn't consider
move lines without a linked sale line. That would end up in inconsistent
calculations and even the original line rewriting.

TT38863
- In standard report, Odoo always show qty_done
Currently translated at 100.0% (23 of 23 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/pt/
sofien-moalla and others added 14 commits November 19, 2025 15:01
Currently translated at 73.9% (17 of 23 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/fr_FR/
Currently translated at 100.0% (23 of 23 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/it/
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-reporting-17.0/stock-logistics-reporting-17.0-stock_picking_report_valued
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-17-0/stock-logistics-reporting-17-0-stock_picking_report_valued/it/
We make sure that the currency_id field always has a value to avoid errors. For example, when installing this module with stock_picking_report_delivery_cost and running the tests, there is a case where the picking has no currency defined, which blocks the CI.
@pedrobaeza
Copy link
Member

/ocabot migration stock_picking_report_valued

Please take into account #450

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Nov 24, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 24, 2025
16 tasks
@arantxa-s73
Copy link
Author

@pedrobaeza this is added

@arantxa-s73 arantxa-s73 force-pushed the 19.0-mig-stock_picking_report_valued branch from cf054f1 to 198f1a2 Compare November 28, 2025 10:49
Copy link

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@arantxa-s73 arantxa-s73 force-pushed the 19.0-mig-stock_picking_report_valued branch from 198f1a2 to 2aead4a Compare January 7, 2026 07:45
arantxa-s73 and others added 2 commits January 7, 2026 09:31
The way the fields were calculated has been modified, since after performing the new() function, it recalculates the fields and loses them, only showing the unit price at the end. Therefore, it has been modified so that if it has a quantity different from the sales order or a different UOM, it first calculates the subtotal price and then performs the new() function. This way, the prices are calculated correctly in the report and the lines.
@arantxa-s73 arantxa-s73 force-pushed the 19.0-mig-stock_picking_report_valued branch from 2aead4a to 3d34d01 Compare January 7, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.