[14.0][MIG] mig_mail_alias_with_domain#1800
Open
ntsirintanis wants to merge 7 commits intoOCA:14.0from
Open
Conversation
[FIX] mail_alias_with_domain: review remarks
Author
|
@NL66278 I cherry-picked the improvements commit from 16.0 |
|
@ntsirintanis Great, but please merge the fixup commit with the one before, because this can not be done on github merge. |
- Add test for write on mail.alias; - No unneeded call to clean already clean email; - Add constraint to mail.alias.
ntsirintanis
force-pushed
the
14.0-mig-mail_alias_with_domain
branch
from
9ce6cdb to
11d7614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #1797