Conversation
NL66278
force-pushed
the
16.0-mig-mail_alias_with_domain
branch
2 times, most recently
from
eebecec to
00055d5
Compare
NL66278
changed the title
NL66278
force-pushed
the
16.0-mig-mail_alias_with_domain
branch
2 times, most recently
from
64a79d7 to
adab305
Compare
|
Test fail on another module. Can be corrected after merge of this PR: #1628 |
NL66278
force-pushed
the
16.0-mig-mail_alias_with_domain
branch
from
adab305 to
e17f18e
Compare
| emails = {email for email in (tools.email_split(message_dict["recipients"]))} | ||
| alias_names = [] | ||
| for email in emails: | ||
| clean_email = Alias.get_clean_email(email) |
There was a problem hiding this comment.
in which cases does email_split return something else than an email address?
|
|
||
| alias_entry = fields.Char( | ||
| help="This will be used to enter an email, complete with domain", | ||
| ) |
| @api.depends("alias_name") | ||
| def _compute_alias_domain(self): | ||
| alias_with_domain = self.filtered( | ||
| lambda r: r.alias_name and "__at__" in r.alias_name |
There was a problem hiding this comment.
I don't find it super far fetched to have this in a mail address. did you consider using a character illegal in both localparts and domain names, like '&'?
There was a problem hiding this comment.
@hbrunn Taken up most of your remarks in new PR here: #1797
Only not this one. Using & led to other problems, and apparently is actually allowed also, just like _ and most printable characters. At least according to this site: https://www.ditig.com/characters-allowed-in-email-addresses. But even if __at__ is used in some email address - never encountered anything like it -, it will be extremely unlikely that this also will coincide with en email address used as an alias.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
3 participants
Make it possible to handle incoming mails with aliases that take the smtp domain of the incoming mail into account. So you can have mail addresses like invoice@my_one_company.com and invoice@my_other_company.com and link them to records in the right company.